Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
18 May 2015

This fixes issue #40:

Duplicate column name 'version' SQL=ALTER TABLEp52jk_weblinksADD COLUMNversionint(10) unsigned NOT NULL DEFAULT '1';

This message shows when updating Joomla 3.3.6 to 3.4.1 upload and install the weblinks RC package.

avatar wilsonge wilsonge - open - 18 May 2015
avatar wilsonge wilsonge - change - 18 May 2015
Milestone Added: 3.4.1
avatar zero-24
zero-24 - comment - 18 May 2015

@test successful with the changes above and in combination with #42 Great work!

avatar dongilbert
dongilbert - comment - 18 May 2015

Why is this not using the query builder?

avatar mbabker
mbabker - comment - 18 May 2015

IIRC the database code in general doesn't have support for queries that change table schemas.

avatar dongilbert
dongilbert - comment - 18 May 2015

That should be remedied, but probably not in this PR, obv.

avatar wilsonge
wilsonge - comment - 19 May 2015

If we could deal with adding and removing columns 99% of extension update SQL files could be killed in one swift chop

avatar zero-24
zero-24 - comment - 19 May 2015

Also successful tested by @infograf768 #44 (comment)

With my package and #41 (comment) included.

Thanks!

avatar javigomez
javigomez - comment - 19 May 2015

Works!

screen shot 2015-05-19 at 13 46 22

avatar javigomez
javigomez - comment - 19 May 2015

pushed at c23179f. Closing this pull.

avatar javigomez javigomez - close - 19 May 2015
avatar wilsonge wilsonge - head_ref_deleted - 19 May 2015

Add a Comment

Login with GitHub to post a comment