[#387] - Don't strip Time info
- New
- Medium
- Build: master
- # 387
- Diff
- okonomiyaki3000:patch-1
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
User tests: Successful: Unsuccessful:
There is no need to strip the time info from the created column. This information might be useful in case of timezone differences or whatever. Let the formatting be done at the template level.
Pull Request for Issue # .
Summary of Changes
Removed this from the database query:
DATE_FORMAT(a.created, "%Y-%m-%d") AS created
Because why wouldn't you want the full datetime info?
Testing Instructions
Create a weblinks module. It should display the same way with or without the patch.
Expected result
No direct change expected.
Actual result
No direct change actually.
Documentation Changes Required
No
Hello? Somebody want to have a look at this? This build failure has nothing to do with this PR. Please fix your Travis and run it again.
Hey! Fix your travis and merge this patch, ok?
Hello? Anybody home in here? Your Travis is drunk and this a solid improvement. Let's get it merged.
Is this the appropriate time to open the infamous "is this repo abandoned" issue?
Needs at least one test, than I merge it. Not sure if there was a reason to add the strip before hand.
despite Travis
it works as expected
Just take this damn patch. It's obviously nonsense to strip the time information here. Why would you do that?
i'm afraid this is abandonware
@wilsonge and @HLeithner should have the propper access to merge things here :)
I'm sure that this failure has nothing to do with me. Isn't there a problem with Travis?