Failure

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
11 Jan 2018

Pull Request for Issue #361 .

Summary of Changes

Wraps the code into a try/catch which will return '' in case a fatal error was discovered.

Testing Instructions

Try to build the weblinks package by running vendor/bin/robo.bat buildon a Windows machine. Of course first make sure to have composer stuff installed.

Expected result

Packages are created in /dist

Actual result

Fatal Error

Documentation Changes Required

We need better documentation on how to build the packages anyway. There is documentation on how to run the tests, but I didn't found explanantions how to actually build the packages.

avatar Bakual Bakual - open - 11 Jan 2018
avatar Bakual
Bakual - comment - 11 Jan 2018

Actually, it only fixes the creating of dist/weblinks-3.7.0. I don't get the zipfiles created.

avatar astridx
astridx - comment - 11 Jan 2018

Everything fits in Ubuntu :)
Hopefully this will also test someone under Windows.

avatar Bakual Bakual - change - 4 Apr 2019
Status New Closed
Closed_Date 0000-00-00 00:00:00 2019-04-04 17:05:49
Closed_By Bakual
avatar Bakual Bakual - close - 4 Apr 2019
avatar Bakual Bakual - close - 4 Apr 2019
avatar Bakual Bakual - head_ref_deleted - 4 Apr 2019

Add a Comment

Login with GitHub to post a comment