[#346] - Add Support for translating one item via Multilingual Associations
- Closed
- 16 May 2017
- Medium
- Build: master
- # 346
- Diff
- astridx:associations
- Success continuous-integration/drone/pr the build was successful Details
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
User tests: Successful: Unsuccessful:
Testing Instructions
Create a weblink item and translate it via Multilingual Associations Component
Expected result
Up to now we only support translation of categories. With this PR it is possible to translate also weblink items.
we never added associations for individual weblinks as they make no sense.
this should be closed.
we never added associations for individual weblinks as they make no sense.
this should be closed.
@infograf768 as with 3.7.1 release of weblinks we will have a single weblink view wich would make sense to be translated IMO
i don't think you understand : it just does NOT make sense. Cliking on a web link displays in another page, not in joomla. this means tha the switcher can never be used. you just can't associate them. period. you can associate their categories and display them in function of the language but not associate them.
Please check: #336 @infograf768 this is a new feature we are trying to release with a new release of weblinks.
hmm... are you sure all this is really useful?
I have tested this item
Missing Lang.-String:
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/weblinks/346.
@franz-wohlkoenig Thank you very much for testing. The missing string is in there now.
@infograf768 You are right. The single view is not really neccessary. But I think weblinks is a component where others (and I) have the opportunity to learn creating componentens. Thats why I think the single view is OK.
@astridx
As I am not sure both your patches take care of all aspects of associations, I have done here a full implementation of associations for weblinks, which also let's set the assoc when editing a weblink (not through multilingual assocations) as we do for other core components.
It is based on the existing release version of weblinks, but I am sure it will be easy for you to see the .diff with this master one.
Example (without the new ini strings)
I let you look and implement it if it does not yet exists in your patches.
See patch below
Here it is
@infograf768
Thank you very much. I (and surely @zero-24) will have a closer look on it next week.
Note: there will be some corrections to do in my patch concerning the lang strings.
Some strings have to be moved from the sys.ini to the .ini, one string is missing, another one needs correcting the constant in the code.
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-16 09:24:24 |
| Closed_By | ⇒ | astridx |
Some checks are not successful:
The first one: tests/acceptance/install/InstallWeblinksCest.php:installJoomla failed
It fails because of a spellchange in the danish Languagefiles. This change is fixed in Joomla Browser, but we do not use the current Version of JoomlaBrowser ...