[#338] - only support mod_stats and mod_stats_admin
- Fixed in Code Base
- 21 Apr 2017
- Medium
- Build: master
- # 338
- Diff
- zero-24:modstats
- Success continuous-integration/drone/pr the build was successful Details
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
User tests: Successful: Unsuccessful:
Summary of Changes
Only support mod_stats and mod_stats_admin
Testing Instructions
Testing Instructions
- install 3.7.0 (as this is a new plugin event)
- Create at least one published web link.
- apply this pr
- You also need to apply this too: joomla/joomla-cms#15138
- discover the new plugin
- install it
- Enable the system plugin.
- You should now have an entry about the weblinks count.
Expected result
You should now have an entry about the weblinks count.
Actual result
No weblinks stats in the frontend.
Documentation Changes Required
None.
| Milestone |
Added: Weblinks 3.7.0 |
||
can you apply this one manually (few lines)...
...don't know if there is a "cool" way
...don't know if there is a "cool" way
the cool way is called git :P But yes this looks like a limitation of patchtester. Can you manually apply the changes?
too cool for my git knowledge level
will try to append manually. I'm so uncool.
Thanks
in which System Plugin and where to add Method?
This is the part i have done here for weblinks ;) So if you have applyed both your are done :)
I have to apply this PR and #15138 – both at same Time don't work. Now i try to append Method manually and don't know in which Plugin the Method i have to apply.
if you have the CMS PR applyed. Than you only need to change the files in this PR manually. As i have changed here the weblinks plugin that handle that. So you can test both on the same time
you mean with "System Plugin" the Weblinks-Plugin in there i put Method – anywhere?
You have installed weblinks. So you can just go to this file: plugins/system/weblinks/weblinks.php and do the changes i have done in this Pull request. https://github.com/joomla-extensions/weblinks/pull/338/files than you don't need to add any new moethod as it is allready there.
The example with the new method was if you don't have a method + plugin for that yet.
If you want to add a method you can do this in any system plugin. But you don't need to do that as weblinks already have that method in the file above
Installed weblinks 3.6.0, created a Weblink. Got no Weblinks-Folder:
"Components > com_weblinks > weblinks.php"?
Ah you are correct. this is only in the 3.7 version of weblinks wich is not released yet. I can build the plugin itself when i'm back at home today.
Fine, so i get new Instructions later.
You can apply the CMS PR plus this plugin. (it already include the changes in this PR here)
weblinks.zip
I have tested this item
Backend
Frontend
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/weblinks/338.
Thanks
yvesh
- | Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-04-21 17:24:31 |
| Closed_By | ⇒ | yvesh |
Thanks !
seems not possible to apply joomla/joomla-cms#15138 & this PR at once. Installed first #15138, changed in Options Repository to "Weblinks" and couldn't fetch data cause PR is applied.