i'm unable to select an existing weblink when i create a new menu item of the weblink item type
tested on a MultiLanguage site

@alikon
Thank you very much for testing.

For choosing a already created weblink a file in the media folder is responsible.
I just installed a new joomla-cms and applied the patch. I realized, that the data I created in the media folder, are not created via the patch tester.

I added this folder in the xml-file: https://github.com/joomla-extensions/weblinks/pull/336/files#diff-ca7e22c702629b3fa6a44ae18e15ee3aR36

Did i forgot something?

i'll double check, cause i've used com_patchtester...

added the js file all works fine

I have tested this item ✅ successfully on 0c885e1

@alikon Thank you very much.
Does any one know why patch tester did not add the files from the media folder automaticly.

@astridx i have just tested this but it looks like the fields are missing in the frontend. I would suggest to use the onContent over the onWeblink events. For the normal backend we are also using the onContent events.

If i use the onContent events it is working great.

I'm just thinking loud.

Don't we need to wait to release a version with the new strings until they are added to the CMS and forwarded to the tranlation teams?

So we can ship this things first if this works and is merged but the strings are merged to the CMS too so the TT's got a chance to translate them?

This would mean this feature (this an my PR) is part of an weblinks 3.7.1 realase (short after 3.7.1 is out) ? Or I'm missing something?

cc @yvesh ?

@zero-24 Thank you. I changed the events.

Great. Can you also alpha order the new language strings in the language file? If i get some time when i'm back home i can send you some tweeks for the layout files (use opening and closing PHP statments per line).

If that is sorted we need to take a decision over the general issue i have raised above.

Than this is ready to be released (together with my other PR :)

?

@astridx i have just send you a PR: astridx#2 wich should fix the most smal errors.

Please take a look into the two inline comments I made here.

Based on the Feedback by @yvesh in the Weblinks Chat I'm going to change the milestone to 3.7.1 so this is going to be merged short after 3.7.0 weblinks is released and the language strings are getting moved as quick as possible to the CMS to be included in 3.7.1 too. Thanks!

If I am right, there is no open issue or question in the conversation of this PR at the moment, right?

The only one is this line +

@infograf768 Thank you for reviewing.
I fixed all issues.

I posted for you some files to implement associations when editing the weblink and in its manager on #346

It is now a full .diff which would make this PR as well as #346 obsolete.

See #346 (comment)

close because of #349