User tests: Successful: Unsuccessful:
This PR backports: joomla/joomla-cms#6134 to the weblinks repo and fixes: #28
@QkiZMR I'm not sure what you mean?
The PR is the last change at the corresponding files e.g.: https://github.com/joomla/joomla-cms/commits/staging/components/com_contact/views/categories/tmpl/default.php
At https://github.com/joomla/joomla-cms/pull/6134/files webpage I have to delete lines 25-27 from components/com_contact/views/categories/tmpl/default.php file.
25: -
26: -echo JLayoutHelper::render('joomla.content.categories_default', $this);
27: -echo $this->loadTemplate('items');
But on my server that files contains
25: ?>
26:
That's because we shipped that change in 3.4.1 - so it should already be deleted on your install for com_contact :)
I don't know why but my previous post is cropped
So how these changes (https://github.com/joomla/joomla-cms/pull/6134/files) relate to my problem (#28) ???
Because weblinks is no longer shipped as part of Joomla Core. All you need to apply is the changes in this Pull Request (https://patch-diff.githubusercontent.com/raw/joomla-extensions/weblinks/pull/33.diff) on com_weblinks on 3.4.1
Now it's working. Zero-24 introduces unnecessary mess in conversation giving me link to diffs that not related to my problem.
He did everything correctly by linking us maintainers to what introduced the problem making the bug fixing process easier. Thankyou for testing this.
I guess we can move this to RTC as we have a similiar PR (#36), a successful test here and successful tests by users in germany (http://www.joomlaportal.de/joomla-3-x-installation/313482-sammelthread-upgrade-von-2-5-auf-3-3-welche-vorgehensweise-ist-hilfreich-29.html#post1589395)
Thanks
Milestone |
Added: 3.4.1 |
Diff files from https://github.com/joomla/joomla-cms/pull/6134/files doesn't match to files from my Joomla ver. 3.4.1 Stable