Pending

User tests: Successful: Unsuccessful:

avatar zero-24
zero-24
9 Apr 2015

This PR backports: joomla/joomla-cms#6134 to the weblinks repo and fixes: #28

avatar zero-24 zero-24 - open - 9 Apr 2015
avatar QkiZMR
QkiZMR - comment - 9 Apr 2015

Diff files from https://github.com/joomla/joomla-cms/pull/6134/files doesn't match to files from my Joomla ver. 3.4.1 Stable

avatar zero-24
zero-24 - comment - 9 Apr 2015

@QkiZMR I'm not sure what you mean?

The PR is the last change at the corresponding files e.g.: https://github.com/joomla/joomla-cms/commits/staging/components/com_contact/views/categories/tmpl/default.php

avatar QkiZMR
QkiZMR - comment - 9 Apr 2015

At https://github.com/joomla/joomla-cms/pull/6134/files webpage I have to delete lines 25-27 from components/com_contact/views/categories/tmpl/default.php file.

25: -
26: -echo JLayoutHelper::render('joomla.content.categories_default', $this);
27: -echo $this->loadTemplate('items');

But on my server that files contains

25: ?>
26:

avatar wilsonge
wilsonge - comment - 9 Apr 2015

That's because we shipped that change in 3.4.1 - so it should already be deleted on your install for com_contact :)

avatar QkiZMR
QkiZMR - comment - 9 Apr 2015

I don't know why but my previous post is cropped

avatar QkiZMR
QkiZMR - comment - 9 Apr 2015

So how these changes (https://github.com/joomla/joomla-cms/pull/6134/files) relate to my problem (#28) ???

avatar wilsonge
wilsonge - comment - 9 Apr 2015

Because weblinks is no longer shipped as part of Joomla Core. All you need to apply is the changes in this Pull Request (https://patch-diff.githubusercontent.com/raw/joomla-extensions/weblinks/pull/33.diff) on com_weblinks on 3.4.1

avatar QkiZMR
QkiZMR - comment - 9 Apr 2015

Now it's working. Zero-24 introduces unnecessary mess in conversation giving me link to diffs that not related to my problem.

avatar wilsonge
wilsonge - comment - 9 Apr 2015

He did everything correctly by linking us maintainers to what introduced the problem making the bug fixing process easier. Thankyou for testing this.

avatar zero-24
zero-24 - comment - 12 Apr 2015

I guess we can move this to RTC as we have a similiar PR (#36), a successful test here and successful tests by users in germany (http://www.joomlaportal.de/joomla-3-x-installation/313482-sammelthread-upgrade-von-2-5-auf-3-3-welche-vorgehensweise-ist-hilfreich-29.html#post1589395)

Thanks :smile:

avatar wilsonge wilsonge - reference | - 12 Apr 15
avatar wilsonge wilsonge - merge - 12 Apr 2015
avatar wilsonge wilsonge - close - 12 Apr 2015
avatar wilsonge wilsonge - change - 12 Apr 2015
Milestone Added: 3.4.1
avatar zero-24 zero-24 - head_ref_deleted - 13 Apr 2015

Add a Comment

Login with GitHub to post a comment