[#325] - Frontend view single weblink
- Fixed in Code Base
- 24 Mar 2017
- Medium
- Build: master
- # 325
- Diff
- astridx:frontend_view_single_weblink
- Success continuous-integration/drone/pr the build was successful Details
- Failure continuous-integration/travis-ci/pr The Travis CI build failed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #211.
Summary of Changes
Add a basic front end view so that zero-24 can go on with the rendering in the frontend for custom fields #317
Testing Instructions
Apply this patch on a 3.7 version
Expected result
Your can apply a single weblink for a menu item in the frontend.
Actual result
None
I've been looking at com_content.
Documentation Changes Required
Yes
Addition
I just realized, that I forgot to put the weblink in the frontend view into a <a href=>- tag. I will add that if you like my suggestion so far.
I've been picked much from com_content.
| Milestone |
Added: Weblinks 3.7.0 |
||
@franz-wohlkoenig Thank you for testing.
I just tried to apply the patch via patch tester. For me it worked.
I used patch tester version 3.0.0 beta (https://github.com/joomla-extensions/patchtester/releases/tag/3.0.0-beta2) on the current Joomla! 3.7.0-rc1 dev.
Perhaps someone else knows why @franz-wohlkoenig gets the error message?
i know: to many reinstalls, so no weblinks installed.
I have tested this item
- Title and Url is shown, not clickable
- Weblink created in Modal is locked (similar Categories and Articles)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/weblinks/325.
i have tested against 3.7.0-rc1, as i know should be tested on 3.6.5 but theres now the 3.7-milestone.
@franz-wohlkoenig we are going to release a 3.6 version of weblinks soon
@franz-wohlkoenig Thank you for testing :)
I just added the forgotton link to the Url. I did not link the title.
If someone else has other ideas and I can implement that, I will do this. I'm not very creative at the moment :( I am also open to any criticism.
I have tested this item
Menu Single Weblink: Click on Select Weblink > in Modal click on an Weblink got no response.
No Message on JS in Browser-Console.
Test on
weblinks-3.6.0
macOS Sierra, 10.12.3
Firefox 52.0 (64-bit)
MAMP 4.1.1
- PHP 7.0.15
- MySQLi 5.6.35
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/weblinks/325.
Thank you very much for your tests.
If I understand you correctly, your problem occurred when creating the menu item for the single weblink. I did not really change anything in the code for this.
Did you assign the patch with the help of the pathtester component? Did you tested on the same machine as last time?
Problem is to click on an Weblink in the Modal – noting happens. So you cant select a Weblink to assign to Menu.
I added this PR on same Machine, Difference is i use latest nightly builds from Today.
Thank you for the quick reply :)
| Status | New | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-24 10:51:32 |
| Closed_By | ⇒ | astridx |
| Milestone |
Removed: Weblinks 3.7.0 |
||
After installing PR got
Error: The file marked for modification does not exist: administrator/components/com_weblinks/weblinks.xml, PR not installed.