Failure

User tests: Successful: Unsuccessful:

avatar chrisdavenport
chrisdavenport
28 Dec 2016

Pull Request for Issue joomla/joomla-cms#13386.

Summary of Changes

Move web links statistics shown on the admin control panel from Joomla core to a system plugin in the web links package.

Testing Instructions

  • Create at least one published web link.
  • Enable the new web links system plugin.
  • You should now have 2 entries for web links on the control panel, unless the core PR has been merged first in which case you should have just one entry (with a link).
avatar chrisdavenport chrisdavenport - open - 28 Dec 2016
avatar yvesh
yvesh - comment - 30 Dec 2016

Tested, works as expected.

For __DEPLOY_VERSION__ we have to adjust the build tool.

Btw. Is the issue tracker still working with weblinks? Looks like i can't test this one with it..

avatar alikon
alikon - comment - 30 Dec 2016

the weblink issue tracker is not updated the max(id) is 279 < 288

tested successfully

avatar mbabker
mbabker - comment - 30 Dec 2016

Btw. Is the issue tracker still working with weblinks?

All of the webhooks for this repo are failing to send data, probably means ModSec is blocking the payloads.

avatar mbabker
mbabker - comment - 30 Dec 2016

Nevermind, the issue was actually in the webhook configuration on this repo. I've fixed it for you.

avatar astridx
astridx - comment - 8 Jan 2017

I tested this patch successfully

  1. I created a weblink.
  2. I created a menu item and clicked the weblink one time and I saw one hit.
  3. I created an admin module of the type statistic. I see no entry for this in the module because the core patch is merged.
  4. After that I copied the system plugin from this patch into the system plugin folder of my installation, discovered it and activated it.
  5. After that I saw an entry for my weblink in the statistic module

Only one little point. My code sniffer told me that he expected 2 spaces after the longest type in line 32 oft the class PlgSystemWeblinks.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Jan 2017

After "Apply Patch" in Patchtester got Error: The file marked for modification does not exist: pkg_weblinks.xml

avatar yvesh
yvesh - comment - 13 Jan 2017

@franz-wohlkoenig You can't use patch tester here. The package needs to be rebuild with the patch, see README.md

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Jan 2017

@yvesh Sorry, had changed in Patchtester the GitHub Repository from "Joomla cms" to "Joomla weblinks package" and thought this works.

avatar astridx
astridx - comment - 13 Jan 2017

Can't we use patch tester only for this patch or can' t we use it at all?
It is already explained in the read.me file :)

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 13 Jan 2017

Maybe my English isn't good enough so i understand read.me i can test weblinks-repo by patchtester.

avatar mbabker
mbabker - comment - 13 Jan 2017

Can't we use patch tester only for this patch or can' t we use it at all?

You should be able to test weblinks with patch tester, but the weblinks package would need to be installed first.

avatar mbabker
mbabker - comment - 13 Jan 2017

Oh, wait, I see the problem now. Why is there a package manifest at both src/pkg_weblinks.xml and src/administrator/manifests/packages/pkg_weblinks.xml?

avatar astridx
astridx - comment - 13 Jan 2017

I tried the patch tester for com_weblinks too this evening.
Patches that contain existing files show the error. But a patch with contains only a new file (#294) shows no error message. It shows a success message but it did not copy the file.

avatar zero-24 zero-24 - change - 13 Feb 2017
Milestone Added: Weblinks 3.7.0
avatar zero-24 zero-24 - change - 13 Feb 2017
Milestone Added: Weblinks 3.7.0
avatar zero-24
zero-24 - comment - 15 Feb 2017

@chrisdavenport can you please sync to master here please?

avatar zero-24
zero-24 - comment - 24 Mar 2017

Closing as this PR is not updated since more than one month. I have opend an new PR here: #333 please test.

avatar zero-24 zero-24 - close - 24 Mar 2017
avatar zero-24 zero-24 - change - 24 Mar 2017
Status New Closed
Closed_Date 0000-00-00 00:00:00 2017-03-24 12:07:01
Closed_By zero-24

Add a Comment

Login with GitHub to post a comment