User tests: Successful: Unsuccessful:
Pull Request for Issue joomla/joomla-cms#13386.
Move web links statistics shown on the admin control panel from Joomla core to a system plugin in the web links package.
the weblink issue tracker is not updated the max(id) is 279 < 288
tested successfully
Btw. Is the issue tracker still working with weblinks?
All of the webhooks for this repo are failing to send data, probably means ModSec is blocking the payloads.
Nevermind, the issue was actually in the webhook configuration on this repo. I've fixed it for you.
I tested this patch successfully
Only one little point. My code sniffer told me that he expected 2 spaces after the longest type in line 32 oft the class PlgSystemWeblinks.
After "Apply Patch" in Patchtester got Error: The file marked for modification does not exist: pkg_weblinks.xml
@franz-wohlkoenig You can't use patch tester here. The package needs to be rebuild with the patch, see README.md
Can't we use patch tester only for this patch or can' t we use it at all?
It is already explained in the read.me file :)
Maybe my English isn't good enough so i understand read.me i can test weblinks-repo by patchtester.
Can't we use patch tester only for this patch or can' t we use it at all?
You should be able to test weblinks with patch tester, but the weblinks package would need to be installed first.
Oh, wait, I see the problem now. Why is there a package manifest at both src/pkg_weblinks.xml
and src/administrator/manifests/packages/pkg_weblinks.xml
?
Milestone |
Added: Weblinks 3.7.0 |
Milestone |
Added: Weblinks 3.7.0 |
@chrisdavenport can you please sync to master here please?
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-03-24 12:07:01 |
Closed_By | ⇒ | zero-24 |
Tested, works as expected.
For
__DEPLOY_VERSION__
we have to adjust the build tool.Btw. Is the issue tracker still working with weblinks? Looks like i can't test this one with it..