Failure

User tests: Successful: Unsuccessful:

avatar chrisdavenport
chrisdavenport
30 Nov 2016

Pull Request for Issue #282 .

Summary of Changes

PHP and JS headers were changed during the 3.6.0-beta release procedure. This PR fixes the source of that problem.

Testing Instructions

Run vendor/bin/robo headers and check that headers in PHP and JS files are correct.

avatar chrisdavenport chrisdavenport - open - 30 Nov 2016
avatar zero-24
zero-24 - comment - 30 Nov 2016

I guess you missed to run the script? Btw if you add the subpackage tag again we dont need to change the spaces ;)

avatar chrisdavenport
chrisdavenport - comment - 30 Nov 2016

Is that better?

avatar zero-24
zero-24 - comment - 30 Nov 2016

CS is done now. The 5.6 fail is now something different (something about a screenshot) maybe @yves can help there?

avatar yvesh
yvesh - comment - 1 Dec 2016

@zero-24 It's the usual Travis hickup, rest looks fine.

avatar yvesh yvesh - reference | bb4b0bf - 1 Dec 16
avatar yvesh yvesh - merge - 1 Dec 2016
avatar yvesh yvesh - close - 1 Dec 2016
avatar yvesh
yvesh - comment - 1 Dec 2016

Thanks @chrisdavenport ?

avatar zero-24 zero-24 - change - 16 Feb 2017
Milestone Added: 3.6.0

Add a Comment

Login with GitHub to post a comment