Failure

User tests: Successful: Unsuccessful:

avatar photodude
photodude
29 Nov 2016

Pull Request for Issue add php 7.1 and hhvm to tests.

Summary of Changes

add php 7.1 and hhvm

Testing Instructions

tests are allowed to fail, merge by code review (i.e. test actually run)

avatar photodude photodude - open - 29 Nov 2016
avatar zero-24
zero-24 - comment - 29 Nov 2016

hmm i would not allow 7.0 and 7.1 to fail.

The PHP CS Checks fails on other problems but 7.0 and 7.1 run fine.

avatar photodude
photodude - comment - 30 Nov 2016

@zero-24 the allowed fail change has been implemented

avatar zero-24
zero-24 - comment - 30 Nov 2016

?

avatar yvesh yvesh - reference | f44c951 - 30 Nov 16
avatar yvesh yvesh - merge - 30 Nov 2016
avatar yvesh yvesh - close - 30 Nov 2016
avatar yvesh
yvesh - comment - 30 Nov 2016

@photodude Thank you

avatar photodude photodude - head_ref_deleted - 30 Nov 2016
avatar photodude
photodude - comment - 30 Nov 2016

You are welcome @yvesh

Add a Comment

Login with GitHub to post a comment