Joomla! Issue Tracker - Weblinks

Download
Launch
Feeling Lucky

[#278] - UseGlobal or list fields

RTC enhancement Failure

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
16 Nov 2016

Pull Request for Issue #277.

Summary of Changes

Adding the new feature "Show Global Value" to list fields.

Testing Instructions

  1. Make sure to save the weblink and menu options so the global values are saved
  2. Create a weblink / a weblink menu item and verify that there are "Use Global" options and they show the global value.

Note

This PR if merged raises the minimum requirement for Weblinks to Joomla 3.7.0. In lesser versions, the "Use Global" option would no longer appear. So we have to also add a check to prevent installation in Joomla 3.6.x and earlier.

avatar Bakual Bakual - open - 16 Nov 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 16 Nov 2016

I have tested this item ✅ successfully on efa21b7

works as described

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/weblinks/278.

avatar andrepereiradasilva andrepereiradasilva - test_item - 16 Nov 2016 - Tested successfully
avatar yvesh
yvesh - comment - 17 Nov 2016

@Bakual can you look into the indention / formatting of the XML files? ?

Thank you!

avatar yvesh yvesh - change - 17 Nov 2016
Milestone Added: Weblinks 3.7.0
avatar Bakual
Bakual - comment - 17 Nov 2016

@yvesh What's wrong with the formatting? I adjusted it according our codestyle for the lines I changed. The others I haven't touched.

avatar yvesh
yvesh - comment - 22 Nov 2016

@Bakual like this one: (just noticed that it's not from your PR). There are other issues in the file too (one line per attribute for example).

2016-11-22-17 43 47

avatar andrepereiradasilva
andrepereiradasilva - comment - 22 Nov 2016

@yvesh IMHO that is not the goal of @Bakual PR.

That codestyle change needs to be done in another PR, IMHO. Let's not mix PRs...

avatar yvesh
yvesh - comment - 22 Nov 2016

@andrepereiradasilva yep, you are right. Thought i said that with the last comment ;) Going to create an issue and ping @zero-24 ;)

avatar yvesh
yvesh - comment - 22 Nov 2016

I have tested this item ✅ successfully on efa21b7

Works as expected. Thank you

2016-11-22-19 17 30

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/weblinks/278.

avatar yvesh yvesh - test_item - 22 Nov 2016 - Tested successfully
avatar Bakual
Bakual - comment - 22 Nov 2016

Going to create an issue and ping @zero-24 ;)

Don't create issues for codestyle. If someone wants to work on it, it is easy to run a codestyle checker and find the place that still need work.

avatar zero-24
zero-24 - comment - 12 Mar 2017

@Bakual can you fix the merge conflicts?

avatar Bakual
Bakual - comment - 12 Mar 2017

Rebased and fixed the conflicts.

avatar yvesh yvesh - change - 12 Mar 2017
Status New ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-03-12 12:25:10
Closed_By ⇒ yvesh
avatar yvesh yvesh - close - 12 Mar 2017
avatar yvesh yvesh - merge - 12 Mar 2017
avatar yvesh yvesh - reference | e54849f - 12 Mar 17
avatar yvesh yvesh - merge - 12 Mar 2017
avatar yvesh yvesh - close - 12 Mar 2017
avatar yvesh
yvesh - comment - 12 Mar 2017

Thank you @Bakual and testers

avatar zero-24
zero-24 - comment - 12 Mar 2017

Why you are faster than me @yvesh ? Thanks @Bakual !

avatar Bakual Bakual - head_ref_deleted - 12 Mar 2017

Add a Comment

Login with GitHub to post a comment