?

There should be a manifest script added to the package blocking installs on
older Joomla versions if this is accepted. Otherwise you'll get class not
found errors.

On Friday, August 19, 2016, andrepereiradasilva notifications@github.com
wrote:

Summary of Changes

This PR does for weblinks what was already done and merged for the core.
Replace existing 404 JError for a 403 php exception
(JAccessExceptionNotallowed) when the user does not have access to "Access
Administration Interface" (core.manage).

See also joomla/joomla-cms#11608
joomla/joomla-cms#11608
Testing Instructions

Code review.

You can view, comment on, or merge this pull request online at:

#262
Commit Summary

• Add an exception when not allowed

File Changes

• M src/administrator/components/com_weblinks/weblinks.php https://github.com/joomla-extensions/weblinks/pull/262/files#diff-0 (2)

Patch Links:

• https://github.com/joomla-extensions/weblinks/pull/262.patch
• https://github.com/joomla-extensions/weblinks/pull/262.diff

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#262, or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAWfodqt7FrAyg_euRPdcnlHf9RFpHiwks5qhjWQgaJpZM4Jo65Y
.

There should be a manifest script added to the package blocking installs on older Joomla versions if this is accepted. Otherwise you'll get class not found errors.

i know and has about to write that here.
Yes, must be J! 3.6.3+ to get the correct message in the error or will get an error also but with an incorrect message JAccessExceptionNotallowed not found or something.

Can we move this forward? As we have the same exeption JAccessExceptionNotallowed in the core we can go with it?

this can only be merged if the next weblinks version is only 3.6.3+

@andrepereiradasilva imo weblinks should only support latest stable release. But it's probably a PLT decision needed on that..

@andrepereiradasilva Can you update this PR to block installs prior to 3.6.3? I can't think of any good reason to support earlier versions. Thanks.

i think that should not be related to this PR, but the release itself

Thank you @andrepereiradasilva, we will add a check that we only support latest 3.6 version.