Joomla! Issue Tracker | Weblinks #252 - Create Categories on-the-fly on Link edit form

Closed
20 Oct 2016
Medium
Build: master
# 252
Diff
alikon:patch-5

Success

Success continuous-integration/travis-ci/pr The Travis CI build passed Details

User tests: Successful: Unsuccessful:

alikon
31 Jul 2016

Summary of Changes

Create Categories on-the-fly on Weblink edit form

Testing Instructions

Apply patch
Go to Administrator -> Components -> Weblinks ->Link
Click "New"
Enter link details
on category list, enter a new category name and press "Enter"
(work like the cms feature for content,contact, ect)

8575fa5 31 Jul 2016

Create Categories on-the-fly on Weblink edit form

alikon - open - 31 Jul 2016

60ae007 31 Jul 2016

Create Categories on-the-fly on Weblink edit form

6e425b7 31 Jul 2016

Create Categories on-the-fly on Weblink edit form

yvesh - test_item - 31 Jul 2016 - Tested successfully

yvesh - comment - 31 Jul 2016

I have tested this item ✅ successfully on 6e425b7

Works as expected. Thank you Nicola for your work :-)

_{This comment was created with the J!Tracker Application at issues.joomla.org/weblinks/252.}

alikon - comment - 31 Jul 2016

what is supposed to be the correct CS ?
... i always fight with CS/travis etc..... cause i'm lazy ?

yvesh - comment - 31 Jul 2016

@alikon http://joomla.github.io/coding-standards/?coding-standards/chapters/xml.md

So in this case

<field
    name="catid"
    type="categoryedit"
    extension="com_weblinks"
    label="JCATEGORY"
    description="COM_WEBLINKS_FIELD_CATEGORY_DESC"
    required="true"
    allowAdd="true"
    default=""
 />

85acf4c 31 Jul 2016

CS fix

roland-d - test_item - 31 Jul 2016 - Tested successfully

roland-d - comment - 31 Jul 2016

I have tested this item ✅ successfully on 6e425b7

After applying the patch, I am able to add categories when editing/creating a weblink.

_{This comment was created with the J!Tracker Application at issues.joomla.org/weblinks/252.}

zero-24 - comment - 31 Jul 2016

I guess we should implement ACL checks like: joomla/joomla-cms#11244

yvesh - comment - 31 Jul 2016

@zero-24 But this is maybe something for a second PR imo.

Any ideas how to implement that without duplicate code? That model check should be either in a helper or move into the JModelAdmin itself. What do you think? Else we will have it in so many areas..

9756cd5 31 Jul 2016

Update weblink.xml

488826c 31 Jul 2016

Update weblink.php

fbe3e50 31 Jul 2016

Update weblink.php

zero-24 - comment - 31 Jul 2016

ACL: alikon#4

7f13242 1 Aug 2016

Merge pull request #4 from zero-24/patch-3

alikon - comment - 1 Aug 2016

@zero-24 thanks
merged