system tests / QA Success

User tests: Successful: Unsuccessful:

avatar 810
810
27 Jul 2016
avatar 810 810 - open - 27 Jul 2016
avatar 810
810 - comment - 27 Jul 2016

Php check is working, only there is a issue on the test part with php7.

avatar jatitoam
jatitoam - comment - 27 Jul 2016

It seems we're working on the same :) #248
and having the same problem

avatar 810
810 - comment - 27 Jul 2016

@jatitoam yes i copied your code, but then only php7 works, so I added a check for both versions:

You can see here that the code is correct: Kunena/Kunena-Forum#4198

avatar jatitoam
jatitoam - comment - 27 Jul 2016

Yeah, definitely, I was working on the PHP7-compatibility issue before getting there
Thanks for that

avatar jatitoam
jatitoam - comment - 29 Jul 2016

I sent #250 to improve this PR

avatar yvesh
yvesh - comment - 31 Jul 2016

@810 Jelle, looks like everything is working now. Can you do a final check before we merge it into master branch? :-)

Add a Comment

Login with GitHub to post a comment