User tests: Successful: Unsuccessful:
Pull Request for Issue #209 .
allow to use captcha when submit a weblink
use submit weblink enabling/disabling captcha settings
A couple of issues:
1. If I fail the captcha the page reloads but all the form field entries are lost.
2. Perhaps move the captcha field to the end of the form?
The tooltip text: Type in the textbox what you see in the image is not really matching for Recaptcha version
is like com_contact what should be the correct STRING ?
- Perhaps move the captcha field to the end of the form?
not sure should be better near the submit button ?
- If I fail the captcha the page reloads but all the form field entries are lost.
any help ?
@alikon Not sure on the text. Something more generic maybe, which fits both.
For example: Please answer the security question. But i am not a native speaker. @chrisdavenport What do you think?
If I fail the captcha the page reloads but all the form field entries are lost.
any help ?
This is not going to be implemented easily. For com_users the data the user entered during registration is saved in the session and then loaded again.
I checked with the en-GB team and because "I'm not a robot" is not a question, the suggested text is "Please complete the security check." There is a PR in the CMS repo for the same text: joomla/joomla-cms#10931
Good point about the submit buttons. Actually, I think the buttons should be moved to the end too. See, for example, the contact form.
Should be fairly simple to save the form data in the session as per com_users and also com_contact.
I have tested this item
Works perfectly and looks good. Thanks Nicola.
there is the need to add the lang string to the joomla-cms repo too ?
joomla/joomla-cms#10895 (comment)
...it happens only when editor is CodeMirror...
@alikon it also happens without an editor. But you are right with TinyMCE it's fine.. Probably something which should be fixed in core (the row with buttons need to have width: 100% for the editor line, so there is no free space right of it).
We could fix it for weblinks with the following css:
#editor-xtd-buttons {
width: 100%
}
@chrisdavenport What do you think? Core problem or weblinks?
@alikon @yvesh how about: joomla/joomla-cms#10970
maybe @dgt41 can evaluate my dirty fix on https://github.com/joomla/joomla-cms/blob/staging/templates/protostar/css/template.css#L2609
from
.btn-toolbar {
font-size: 0;
margin-top: 9px;
margin-bottom: 9px;
}
to
.btn-toolbar {
font-size: 0;
margin-top: 9px;
margin-bottom: 9px;
width: 100%;
}
results is clean now, i think...
but i don't know if it is a goog fix .....
Any objections to merging this now?
@alikon The branch now has conflicts (Probably due to Tobias changes related to code style).
I think we can merge this PR. The CSS layout problem is a minor one and only occurs when you have no editor or CodeMirror. We should open an issue at core for that. The css code from Nicola looks fine, but i am not sure if it has side effects.
yes please merge this PR
p.s.
cause i'm unable to find the latest damned branch conflicts
This PR has received new commits.
CC: @chrisdavenport
Okay conflicts resolved. @chrisdavenport you can merge now.
This PR has received new commits.
CC: @chrisdavenport
Merging. Good work everyone. :-)
@alikon Hey Nicola, works fine, but there are some small issues i found so far:
The tooltip text:
Type in the textbox what you see in the image
is not really matching for Recaptcha version 2 (where you don't fill out text boxes, but click images).Some code style issues (see comments).
Thank you!