Failure

User tests: Successful: Unsuccessful:

avatar alikon
alikon
26 Jun 2016

Pull Request for Issue #209 .

Summary of Changes

allow to use captcha when submit a weblink

Testing Instructions

use submit weblink enabling/disabling captcha settings

avatar alikon alikon - open - 26 Jun 2016
avatar yvesh
yvesh - comment - 26 Jun 2016

@alikon Hey Nicola, works fine, but there are some small issues i found so far:

The tooltip text: Type in the textbox what you see in the image is not really matching for Recaptcha version 2 (where you don't fill out text boxes, but click images).

Some code style issues (see comments).

Thank you!

avatar chrisdavenport
chrisdavenport - comment - 26 Jun 2016

A couple of issues:
1. If I fail the captcha the page reloads but all the form field entries are lost.
2. Perhaps move the captcha field to the end of the form?

avatar alikon
alikon - comment - 26 Jun 2016

@yvesh

The tooltip text: Type in the textbox what you see in the image is not really matching for Recaptcha version

is like com_contact what should be the correct STRING ?

@chrisdavenport

  1. Perhaps move the captcha field to the end of the form?

not sure should be better near the submit button ?

  1. If I fail the captcha the page reloads but all the form field entries are lost.

any help ?

avatar yvesh
yvesh - comment - 26 Jun 2016

@alikon Not sure on the text. Something more generic maybe, which fits both.

For example: Please answer the security question. But i am not a native speaker. @chrisdavenport What do you think?

screenshot 2016-06-26 12 13 55

If I fail the captcha the page reloads but all the form field entries are lost.

any help ?

This is not going to be implemented easily. For com_users the data the user entered during registration is saved in the session and then loaded again.

See this code as an example.

avatar chrisdavenport
chrisdavenport - comment - 26 Jun 2016

I checked with the en-GB team and because "I'm not a robot" is not a question, the suggested text is "Please complete the security check." There is a PR in the CMS repo for the same text: joomla/joomla-cms#10931

Good point about the submit buttons. Actually, I think the buttons should be moved to the end too. See, for example, the contact form.

Should be fairly simple to save the form data in the session as per com_users and also com_contact.

avatar wojsmol wojsmol - reference | b7bdef0 - 26 Jun 16
avatar alikon alikon - reference | dbb05c5 - 27 Jun 16
avatar alikon
alikon - comment - 27 Jun 2016
  • session form data
  • captcha & buttons moved down captchadown ....
avatar chrisdavenport chrisdavenport - test_item - 27 Jun 2016 - Tested successfully
avatar chrisdavenport
chrisdavenport - comment - 27 Jun 2016

I have tested this item successfully on d6a18f8

Works perfectly and looks good. Thanks Nicola. ?


This comment was created with the J!Tracker Application at issues.joomla.org/weblinks/223.

avatar alikon
alikon - comment - 27 Jun 2016

there is the need to add the lang string to the joomla-cms repo too ?
joomla/joomla-cms#10895 (comment)

avatar yvesh
yvesh - comment - 28 Jun 2016

@alikon There is a slight css issue for me:

screenshot 2016-06-28 16 44 40

Imo it's not completely related to your PR, even the


element has that issue. This is a clean Joomla! staging / protostar + weblinks installation.

Everything else works as expected, great work Nicola!

avatar alikon
alikon - comment - 28 Jun 2016

@yvesh css is not my "comfort zone"

any help to fix CSS issue ?

avatar alikon
alikon - comment - 29 Jun 2016

...it happens only when editor is CodeMirror...

avatar yvesh
yvesh - comment - 29 Jun 2016

@alikon it also happens without an editor. But you are right with TinyMCE it's fine.. Probably something which should be fixed in core (the row with buttons need to have width: 100% for the editor line, so there is no free space right of it).

We could fix it for weblinks with the following css:

#editor-xtd-buttons {
   width: 100%
}

@chrisdavenport What do you think? Core problem or weblinks?

screenshot 2016-06-29 21 34 38

avatar dgt41
dgt41 - comment - 29 Jun 2016
avatar alikon
alikon - comment - 30 Jun 2016

maybe @dgt41 can evaluate my dirty fix on https://github.com/joomla/joomla-cms/blob/staging/templates/protostar/css/template.css#L2609
from

.btn-toolbar {
    font-size: 0;
    margin-top: 9px;
    margin-bottom: 9px;
}

to

.btn-toolbar {
    font-size: 0;
    margin-top: 9px;
    margin-bottom: 9px;
        width: 100%;
}

results is clean now, i think...
capweblilnk

but i don't know if it is a goog fix .....

avatar yvesh
yvesh - comment - 30 Jun 2016

@alikon looks fine for me, but not sure if that would cause other issues though. You could also just remove the pull-left class the editor-xtd-buttons div has. Not sure why that is there at all?

Is there a case were there is something located right to it on the same line?

// cc @dgt41

avatar chrisdavenport
chrisdavenport - comment - 4 Jul 2016

Any objections to merging this now?

avatar alikon
alikon - comment - 4 Jul 2016

For my knowledge of CSS the issue we have should be fixed on the CMS CSS side
We are waiting for some CSS expert answer which should be the right fix mine or Yves or ...
Evoking @dgt41

avatar yvesh
yvesh - comment - 4 Jul 2016

@alikon The branch now has conflicts (Probably due to Tobias changes related to code style).

I think we can merge this PR. The CSS layout problem is a minor one and only occurs when you have no editor or CodeMirror. We should open an issue at core for that. The css code from Nicola looks fine, but i am not sure if it has side effects.

avatar alikon
alikon - comment - 4 Jul 2016

yes please merge this PR

p.s.
cause i'm unable to find the latest damned branch conflicts ?

avatar jissues-bot
jissues-bot - comment - 4 Jul 2016

This PR has received new commits.

CC: @chrisdavenport

avatar yvesh
yvesh - comment - 4 Jul 2016

@alikon i sent you an PR against your one, merging current master changes into it. (Test please)

avatar yvesh
yvesh - comment - 4 Jul 2016

Okay conflicts resolved. @chrisdavenport you can merge now.

avatar alikon
alikon - comment - 4 Jul 2016

thanks 1000 @yvesh

avatar jissues-bot
jissues-bot - comment - 4 Jul 2016

This PR has received new commits.

CC: @chrisdavenport

avatar chrisdavenport
chrisdavenport - comment - 4 Jul 2016

Merging. Good work everyone. :-)

avatar chrisdavenport chrisdavenport - reference | 1680ec7 - 4 Jul 16
avatar chrisdavenport chrisdavenport - merge - 4 Jul 2016
avatar chrisdavenport chrisdavenport - close - 4 Jul 2016

Add a Comment

Login with GitHub to post a comment