RTC Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
4 May 2016

This PR converts remaining "Weblinks" text to "Web Links" as most of then already are.

Simple test by code review.

avatar andrepereiradasilva andrepereiradasilva - open - 4 May 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 4 May 2016

humm ... should the tests be based on language variables?

avatar puneet0191
puneet0191 - comment - 4 May 2016

@andrepereiradasilva we do it for readability, I understand your point, but for us it saves time, some places we have to do it to solve the purpose of the test. :smile:

avatar yvesh
yvesh - comment - 4 May 2016

@andrepereiradasilva Some are, as it makes the tests easier and more readable. The downside of that you just encountered.. But you have the same when you use CSS / Xpath locators and change styles (h3 -> h2) etc.

avatar andrepereiradasilva
andrepereiradasilva - comment - 4 May 2016

Yes, i understand. Is no easy choice.

Anyway, it's solved now.

avatar puneet0191
puneet0191 - comment - 4 May 2016
avatar yvesh
yvesh - comment - 4 May 2016

@andrepereiradasilva Looks fine too me, based on code review. Thank you ????

avatar andrepereiradasilva
andrepereiradasilva - comment - 4 May 2016

you're welcome guys.

thanks you all for your work in the browser tests!
And always be available to give help when needed!

avatar pritalpatel
pritalpatel - comment - 12 Jun 2016

Thank you for PR. When I was trying to test it using codeception found that space is missing in category and that is why test was failing.
weblink-auto-space-errror

Please add space here in category view.
no-space-weblinks

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Jun 2016

@pritalpatel there are no tests failing. i think that was already solved.

avatar pritalpatel
pritalpatel - comment - 16 Jun 2016

sorry @andrepereiradasilva I was trying to test again this PR. All assertion run smoothly and looks fine.
210weblinks
Thank you.

avatar chrisdavenport chrisdavenport - assigned - 22 Jun 16
avatar chrisdavenport chrisdavenport - reference | d840a7f - 25 Jun 16
avatar chrisdavenport chrisdavenport - merge - 25 Jun 2016
avatar chrisdavenport chrisdavenport - close - 25 Jun 2016
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 25 Jun 2016
avatar infograf768
infograf768 - comment - 26 Jun 2016

The lang strings changes should also be done in the core folders.

Also, should this string (in com_weblinks.sys.ini) be modified from
COM_WEBLINKS_CATEGORIES_VIEW_DEFAULT_DESC="Show all the web link categories within a category."
to
COM_WEBLINKS_CATEGORIES_VIEW_DEFAULT_DESC="Show all the Web Links categories within a category."
on the model of the module:
MOD_WEBLINKS_FIELD_CATEGORY_DESC="Choose the Web Links category to display."

Other discrepancy (typo, lowercase) in the module ini:
MOD_WEBLINKS_XML_DESCRIPTION="This modules displays web links from a category defined in the Web Links component."
and the module sys.ini (typo):
MOD_WEBLINKS_XML_DESCRIPTION="This modules displays Web Links from a category defined in the Web Links component."

Add a Comment

Login with GitHub to post a comment