@brianteeman @MATsxm want to test this one too so weblinks can be consistent with core?

This does not work with Patchtester, but as you can see in the test instructions i made a custom weblinks package with the changes.

Also, i think you have to use the https://issues.joomla.org/tracker/weblinks to mark the test results.

@yvesh reggarding the tests failed, i think this will change some of the browser tests where the filters are selected.

I ask for your help with that.

@yvesh @andrepereiradasilva just merged #205

ok running travis again

ok, now only get the filter failure. https://travis-ci.org/joomla-extensions/weblinks/jobs/127293973#L1992

But i guess that was supposed to happen because this PR changes the filters.

i think somewhere is missing a $I->clickSearchToolsButton :)

Hey @andrepereiradasilva, i fear it's a bit more difficult. Currently working on a fix for you.

But i think there is a bug in your PR: There is no delete button showing up, when you switch to trashed view?

So you can't delete a weblink permanently?

Thank you for your work! ????

i fear it's a bit more difficult.

Never is so simple.

But i think there is a bug in your PR: There is no delete button showing up, when you switch to trashed view?

nice spoted! i will check that!

@andrepereiradasilva The following should fix it, if you want i can also make a pull request to your repository.

$I->click('Search Tools');
$I->wait(2);
$I->selectOptionInChosenById('filter_published', 'Trashed');

Replace line 102 in tests/acceptance/administrator/AdministratorWeblinksCest.php with that.

https://github.com/joomla-extensions/weblinks/blob/master/tests/acceptance/administrator/AdministratorWeblinksCest.php#L102

You also need to update your fork, else you run into new troubles! :-)

This branch is 6 commits ahead, 5 commits behind joomla-extensions:master

will do @yvesh. thanks for the help!

Test passed. All should be fine now. thanks again.

Zip file updated. same URL.

Tested with MySQL and staging. Works as expected, no issues found.

Sytemtests are also working:

PR has some code style issues @andrepereiradasilva in countItems(..)

thanks. ok now?

tests failed, but i think is not related to my PR

@andrepereiradasilva Yes, the travis failure has nothing todo with your PR. It's related to a change in Joomla staging in the installer.

There is already a PR open for that issue in joomla-browser. Should be fixed soon :-)

Thank you for your work! :-)

Thanks @andrepereiradasilva

Tested manually as well as automatically. All seems working fine.

will anyone merge this before it gets conflicts?

Finally got around to reviewing this one. Sorry for the delay.

Looks good. Thanks @andrepereiradasilva Thanks everyone for testing and feedback.