[#199] - Small changes
- Closed
- 14 Aug 2016
- Medium
- Build: master
- # 199
- Diff
- kshitijSharma2014:small-changes
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Made changes in the files as after using the search function using $I->checkAllResults(); doesn't make any sense.
@kshitijSharma2014 hmm you are right, but there should be only one search result. The nice thing in using a method over $I->click(id) is that when it changes in sometime we would just replace it once and not X times ;-)
Maybe you can make a method for JoomlaBrowser out of it? checkFirstResult()?
But nice work, also in finding the missing waitForTexts! Thank you for your contribution!
@yvesh It this PR good to be merged after @kshitijSharma2014's update? Thanks!
javigomez
-
@kshitijSharma2014 can you look into this as we have merge conflicts? or should we close it meanwhile? Thank you!!
@javigomez I have made some small changes in these tests.
Please review.
On PR: joomla-projects/joomla-browser#105
You wrote a comment -" shouldn't you search in the trash to remove only the one menu you just trashed? otherwise you have the risk of removing other trashed menu items not related to your current test"
These changes are made taking it into mind.
Thanks :)