avatar obuisard
obuisard
3 Mar 2016

Identified files are:

  • models/weblink.php
  • tables/weblink.php

in the administration part of the component.

avatar obuisard obuisard - open - 3 Mar 2016
avatar infograf768
infograf768 - comment - 3 Mar 2016

Could you explain exactly the issue? It is unclear to me.

avatar obuisard
obuisard - comment - 3 Mar 2016

Of course!
Joomla\String\String must be replaced with Joomla\String\StringHelper in the code, as part of the changes made in Joomla 3.5 to avoid conflicts with the String class in PHP 7.

avatar yvesh
yvesh - comment - 3 Mar 2016

Joomla\String\String isn't used in weblinks and php7cc does not seem to find any issues in weblinks.

$ php7cc src
Checked 44 files in 3.306 seconds

// Edit: okay sorry @obuisard just noticed you meant the latest release package.. only checked the latest files in the repo.

avatar mbabker
mbabker - comment - 3 Mar 2016

The current repo uses JString. I can't build a package or release or update JED because the folks doing all the automated stuff have zero guidance on using their system (which broke the Phing packager that was used before) and the credentials for the JED that I found aren't valid.

avatar mbabker
mbabker - comment - 3 Mar 2016

@javigomez please post instructions in this repo somewhere so that someone can build a 3.5 compatible weblinks package.

avatar yvesh
yvesh - comment - 3 Mar 2016

@mbabker Build instructions can be found in the README.md file, it's basically just running vendor/bin/robo build after composer install (rename jorobo.dist.ini before) .. manifest.xml isn't touched by the build system atm.

Attached a release build with fixed pkg language file, which is working fine on 3.5 + php7..

pkg-weblinks-3.4.3.zip

avatar obuisard
obuisard - comment - 3 Mar 2016

Thank you!

avatar mbabker
mbabker - comment - 22 Mar 2016

3.5 package tagged.

avatar mbabker mbabker - close - 22 Mar 2016

Add a Comment

Login with GitHub to post a comment