[#18] - Introduce jquery formvalidator for com_weblinks
- Closed
- 8 Feb 2015
- Medium
- Build: master
- # 18
- Diff
- dgrammatiko:jquery_1
User tests: Successful: Unsuccessful:
Executive summary
This PR converts the form validation on com_weblinks to use plain jquery (no mootools call on every form).
Also NO MORE INLINE SCRIPTS!
Testing
- Apply first PR #4888 (!important)
- go to https://raw.githubusercontent.com/dgt41/weblinks/jquery_1/src/com_weblinks/admin/views/weblink/tmpl/edit.php
copy all and paste it to
/administrator/components/com_weblinks/views/weblink/tmpl/edit.php
Also go to https://raw.githubusercontent.com/dgt41/weblinks/jquery_1/src/com_weblinks/admin/views/weblinks/tmpl/default.php
copy all and paste it to
/administrator/components/com_weblinks/views/weblinks/tmpl/edit.php
3. In the admin area go to com_weblinks and try to submit any form.
If no javascript errors are logged in your browser and the functionality remains the same your test is a pass in any other case please report the errors here
Please also check these:
administrator/index.php?option=com_checkin should demonstrate multiselect without mt
administrator/index.php?option=com_users&view=mail should demonstrate form sent and validate without mt
administrator/index.php?option=com_modules should demonstrate multiselect and combobox without mt
http://localhost/administrator/index.php?option=com_admin&view=sysinfo should demonstrate highlighter.js without mt
Logout and log in to demonstrate the use of noframes without mt.
@anibalsanchez Just overwrite those 2 files:
/administrator/components/com_weblinks/views/weblink/tmpl/edit.php
/administrator/components/com_weblinks/views/weblinks/tmpl/edit.php
with the ones from the joomla-extensions/weblinks PR
@anibalsanchez @smanzi Can you retest this one? I removed the jquery .ready(), as it was requested for all these PR’s. If you test it in current staging just overwrite the two files touched here:
/administrator/components/com_weblinks/views/weblink/tmpl/edit.php
/administrator/components/com_weblinks/views/weblinks/tmpl/edit.php
Thanks and sorry for these extra tests
@dgt41 i'm sorry for replying late on this one. I think the code in the second file can just be removed (see joomla/joomla-cms#5994) can you confirm (and remove if appropriate please)?
@wilsonge This ain’t gonna work here as the plural view doesn’t implement the search tools button and thus the script is needed contrary to the category view, but for that there is #5994. I think that this feature (the search tools button) was introduced half baked and not side wide as there are many comments for unneeded filters etc…
Bottom line here, this is good to go as is!
No search tools buttons (js needed)
Search tools button (no js for ordering)
How can it be applied in a plain 3.3.6 ?