[#168] - Fix if 'git' instead of 'git.exe' as command is used on windows
- Closed
- 25 Jun 2016
- Medium
- Build: master
- # 168
- Diff
- peterpeter:windowsGitCommandFix
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
As I'm obviously the only windows user with using 'git' instead of 'git.exe' command, so this fix is only for me ;) And of course for the other possible windows-user in future with the same git configuraton.
Testinstruction:
On clone the jommla-cms:
For all 'windows/git.exe' users it should work as ususal.
For me as 'windows/git' user the 'switch' works.
Sidenote:
The 'unnecessery' if/else structure is to avoid confusing console output as much as possible.
Kubik-Rubik
- 
This is something I've been wondering when we were working on the scripts. For me both git and git.exe works. So why are we going through all the troubles with git.exe? Are there windows installs, where git is not working?
@peterpeter could you confirm that executing git with git(instead of git.exe) fails in your Windows machine.
@javigomez No, otherwise:
As you can read in my initial comment, only 'git' works on my machine. The (windows) common 'git.exe' don't work for me. This fix simply checks on windows, if 'git.exe' as command is available/usable, if not it switches to 'git'.
It seems that there are three possible scenarios for windows:
- only git
- only git.exe
- both
And this fix should catch them all
Seems harmless, if somewhat bizarre. But then that's Windows for you. I'm inclined to just merge it.
@chrisdavenport Most of that RoboFile functionality is going to be outsourced into a different joomla project. All other related RoboFile PRs are mostly just reminders or need some improvements before they can be merged. So i suggest you just close them, we can integrate them later.
I need Windows reviewers here. Can I get your thoughts @compojoom, @yvesh or @Kubik-Rubik ?
thanks