bug

Failure

Failure continuous-integration/travis-ci/pr The Travis CI build failed Details

User tests: Successful: Unsuccessful:

therunnergit
1 Nov 2015

In the config file, the default for "Count Clicks" is "1", but this default was not taken into account in the code.

Steps to reproduce

Install a fresh copy of WebLinks
Open the component options and you will see the "Count Clicks" set to "Yes". Do NOT save the options; just click "Cancel".
Create a new weblink and make sure its "Count Clicks" property is set to "Use Global".
Browse the weblink in the frontend and its href attribute will be the actual URL (e.g. http://www.joomla.org) while in fact it should be something like ...?task=weblink.go&id=1

How to test

After applying the patch, perform the exact steps above and you should see the correct URL.

35e3f1f 1 Nov 2015

therunnergit - open - 1 Nov 2015

Kubik-Rubik - change - 1 Nov 2015

Milestone

Added: 3.4.2

Kubik-Rubik - comment - 1 Nov 2015

I will merge it by code review. Thank you @therunnergit!

Important: We need to provide a PR to fix the test (Francesco is working on it atm).

Kubik-Rubik - reference | f913a99 - 1 Nov 15

Kubik-Rubik - merge - 1 Nov 2015

Kubik-Rubik - close - 1 Nov 2015

therunnergit - reference | 49ad05a - 1 Nov 15