enhancement Success

User tests: Successful: Unsuccessful:

avatar therunnergit
therunnergit
31 Oct 2015

This PR adds a public task to run some code checker tools, namely phpmd, phpcs and phpcpd.
Later on, if we refactor the Robofile.php, they will probably be moved outside it and into the shared tasks.

Usage

To execute any of the given tool, you execute:

vendor/bin/robo run:checker [checkername]

e.g.

vendor/bin/robo run:checker phpmd

How to test

Run the following commands and make sure you get some result:

vendor/bin/robo run:checker phpmd
vendor/bin/robo run:checker phpcs
vendor/bin/robo run:checker phpcpd

Notes

  • The checks are done against the src/ folder.
  • The result will be an error because we DO have code issues to fix, and so the exit code is not 0.
avatar therunnergit therunnergit - open - 31 Oct 2015
avatar Kubik-Rubik
Kubik-Rubik - comment - 31 Oct 2015

Can you please explain in more detail how to test it with one of the checker tools?

avatar therunnergit
therunnergit - comment - 31 Oct 2015

@Kubik-Rubik I updated the original description with more details.

avatar Kubik-Rubik
Kubik-Rubik - comment - 31 Oct 2015

@therunnergit This is great, thank you for the explanation and improvement. Works as described!

avatar therunnergit
therunnergit - comment - 31 Oct 2015

@javigomez improved documentation and used \Robo\Result instead of straight exit codes.

avatar Kubik-Rubik
Kubik-Rubik - comment - 31 Oct 2015

Works with the last change properly!

avatar Kubik-Rubik Kubik-Rubik - change - 31 Oct 2015
Milestone Added: 3.4.2
avatar nn-medienagentur
nn-medienagentur - comment - 31 Oct 2015

@Test running fine. Awesome work!

avatar Kubik-Rubik
Kubik-Rubik - comment - 31 Oct 2015

Thank you @therunnergit! Merged.

avatar Kubik-Rubik Kubik-Rubik - reference | ab8dbab - 31 Oct 15
avatar Kubik-Rubik Kubik-Rubik - merge - 31 Oct 2015
avatar Kubik-Rubik Kubik-Rubik - close - 31 Oct 2015

Add a Comment

Login with GitHub to post a comment