[#118] - Fix for Windows to make sure to run the build command...
- Closed
- 30 Oct 2015
- Medium
- Build: master
- # 118
- Diff
- Kubik-Rubik:build_codeception_windows
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
... to generate AcceptanceTester
With the change the build command is also executed properly on a Windows machine.
How to test
Run the tests and check whether it works on a Windows and non-Windows machine without having called the build command manually first.
This works.
What also works is to do:
$this->_exec('vendor\bin\codecept.bat build');
So we could do a test for windows and execute the above line and for everything else we can run the old line.
I'm not sure which solution is better. If we have the bin folder with all those scripts, should we use it, or should we directly call the codeception files as Viktor did? Ideas? Recommendations?
@Kubik-Rubik I would go instead for the solution that proposes Daniel. Executing the bin file without php in front.
Okay, I will update the PR. Thanks!
zero-24
- | Milestone |
Added: 3.4.1 |
||
| Milestone |
Added: 3.4.2 |
||
| Milestone |
Removed: 3.4.1 |
||
@Test works fine