User tests: Successful: Unsuccessful:
On Windows if you kill the robo script when the repository is being cloned, then a file in .git\objects\pack get's locked (most probably by git.exe).
When we try to delete tests/joomla-cms, we are no longer able to do this. The only possible way to then clone would be to manually delete the folder and run robo after that.
I consider this a more generic case, there's a lot of reasons why you may not be able to delete the folder. I was able to reproduce on Linux by purposefully setting different permissions to the folder, and I can confirm your code provides a correct information message.
@Test works fine.
Milestone |
Added: 3.4.2 |
@compojoom can you please fix conflicts by replacing both occurrences of 'tests/joomla-cms3'
with $this->cmsPath
?
Actually this shouldn't be a windows only problem and you should be able to reproduce it on a mac. When you run robo run:tests and the script starts cloning kill the script when you see the loading percents - like at 20%. Then run the test again. Most probably it will not be able to delete some files, because they are locked.