[#255] - [com_weblinks] Make ACL core.edit.own work (PR for 11466)
- Closed
- 15 Aug 2016
- Medium
- Build: master
- # 255
- Diff
- andrepereiradasilva:acl-edit-own
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue joomla/joomla-cms#11466 (com_weblinks part).
Summary of Changes
The ACL core.edit.own is not working in com_weblinks.
This PR makes it work.
Testing Instructions
- Use latest staging
- Besides the Super User, create a user "test" added to "Administrator" group
- Go to com_weblinks Options, Permissions tab and diable "Edit" for "Administrator" group
- Now create a new weblink with the "test" user (use another browser or a private window)
- Try to edit that item. You can't edit our own. Bug
- Now do the same test but with a weblink category Permission. You can't edit our own. Bug
- Apply patch, repeat step 5. and 6. and now you can edit our own items.
- Code review
Also use the two users to do a general test with the com_weblinks edit permissions to confirm all is fine.
Documentation Changes Required
None.
Notes
This problem was discovered in GsoC 2016 Multilingual project.
This is very similiar with joomla/joomla-cms#11502 (com_newsfeeds) and joomla/joomla-cms#11503 (com_contact).
@andrepereiradasilva i get an SQL syntax error when i apply your patch. System tests also fail because of that
A comma is missing after a.created_by
i've tested successfully
OK here
@alikon @infograf768 Thanks for testing, please use the issue tracker next time like on core :-)
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/weblinks/255.
Didn't even know we have a specific issue tracker for such project.
Found it: https://issues.joomla.org/tracker/weblinks
will this be merged?
And BTW when there will be a new weblinks release?
// cc @chrisdavenport @rdeutz
i guess the test errors have nothing to do with this PR ...