?
avatar Hackwar
Hackwar
21 Oct 2015

In components/com_contact/models/contact.php line 434 a JForm object is created and then send through the form plugin events. If a plugin properly reacts to the context given to the JForm object, namely 'com_users.profile', and tries to edit the XML via removeField() for example, the page crashes with a 500 error, because the JForm object never loaded any XML.

I'm wondering what this code is actually any good for, since it will definitely filter out any data from the user, except for the stuff that is added in in addition to the default data. Considering the amount of additional code that is being executed for this feature, I strongly suggest to drop it. I guess, no one ever used this code and it has been in the system like this for at least 4 years.

avatar Hackwar Hackwar - open - 21 Oct 2015
avatar zero-24 zero-24 - change - 22 Oct 2015
Category Administration Components
avatar zero-24 zero-24 - change - 24 Oct 2015
Labels Added: ?
avatar brianteeman
brianteeman - comment - 3 Aug 2016

@hackwar as no one has replied to you in a long time on this I guess no one has a clue what it does either. We can either close this issue and move along or you can submit a PR to address the issue you ave identified. If no response is received then we will close this in a few weeks.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8120.

avatar brianteeman brianteeman - change - 3 Aug 2016
Status New Information Required
avatar Hackwar
Hackwar - comment - 3 Aug 2016

I will provide a PR.

avatar Hackwar
Hackwar - comment - 3 Aug 2016

and please keep this open to remind me that I write one. 😉

avatar brianteeman
brianteeman - comment - 21 May 2017

@Hackwar are you going to write the PR - its been almost a year - or shall i just close this.

avatar Hackwar
Hackwar - comment - 21 May 2017

Thank you for reminding me. I will look into this in the next 2 weeks. For future-me: If you did not provide a PR for this until June 4th 2017, this will be closed.

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 27 May 2017

Entry on my Calendar for 5th June.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/8120.

avatar Hackwar Hackwar - change - 3 Jun 2017
The description was changed
Status Information Required Closed
Closed_Date 0000-00-00 00:00:00 2017-06-03 07:44:08
Closed_By Hackwar
avatar Hackwar Hackwar - close - 3 Jun 2017
avatar Hackwar
Hackwar - comment - 3 Jun 2017

See #16461 Closing this one. 😄

avatar brianteeman
brianteeman - comment - 3 Jun 2017

Thanks @Hackwar

Add a Comment

Login with GitHub to post a comment