? Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
21 Jul 2015

This is a fix for the previous fix #7313
I'm getting better at fixing my own fixes :smile:

Issue

When having the "state"/"published" filter in the article/module/category manager set to "unpublished", that state should be used as default value when creating a new item. However in this specific case it didn't work.

Solution

My code was only checking if a (boolean) value is present. That works fine for most filters since zero is never a valid case for eg a category or access level. However for the state it is a valid case and thus it failed.
The solution is to use explicite checks instead of the generic boolean check.

Testing

Test creating new articles/categories/modules while you have active filters in Search Tools. The active filters should be preselected in the respective field in the form.
Especially the published/state filter is interesting as that is where it was broken before and now should be fixed.

avatar Bakual Bakual - open - 21 Jul 2015
avatar Bakual Bakual - change - 21 Jul 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Jul 2015
Labels Added: ?
avatar Fedik
Fedik - comment - 23 Jul 2015

test works good

avatar Fedik Fedik - test_item - 23 Jul 2015 - Tested successfully
avatar RickR2H
RickR2H - comment - 27 Jul 2015

Test worked. The only field not responding in the articles and categories is the tags field. But I don't know if this is normal behaviour and that the tags alway have to be newly selected...


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7488.

avatar RickR2H RickR2H - test_item - 27 Jul 2015 - Tested successfully
avatar Bakual
Bakual - comment - 27 Jul 2015

There is no code dealing with the tags. So yes, that is expected behavior.

Setting to RTC.

avatar Bakual Bakual - change - 27 Jul 2015
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 27 Jul 2015
Labels Removed: ?
avatar Bakual Bakual - change - 27 Jul 2015
Milestone Added:
avatar zero-24 zero-24 - change - 27 Jul 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 27 Jul 2015

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7488.

avatar joomla-cms-bot joomla-cms-bot - change - 27 Jul 2015
Labels Added: ?
avatar zero-24 zero-24 - change - 31 Jul 2015
Category Administration
avatar Kubik-Rubik Kubik-Rubik - change - 6 Aug 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-08-06 07:15:43
Closed_By Kubik-Rubik
avatar Kubik-Rubik Kubik-Rubik - close - 6 Aug 2015
avatar joomla-cms-bot joomla-cms-bot - close - 6 Aug 2015
avatar Kubik-Rubik Kubik-Rubik - reference | 327b67e - 6 Aug 15
avatar Kubik-Rubik Kubik-Rubik - merge - 6 Aug 2015
avatar Kubik-Rubik Kubik-Rubik - close - 6 Aug 2015
avatar joomla-cms-bot joomla-cms-bot - change - 6 Aug 2015
Labels Removed: ?
avatar Kubik-Rubik
Kubik-Rubik - comment - 6 Aug 2015

Thank you @Bakual! Merged.

avatar Bakual Bakual - head_ref_deleted - 6 Aug 2015

Add a Comment

Login with GitHub to post a comment