[#7487] - Pagination user manager when Search Tools present
- Closed
- 4 Nov 2015
- Medium
- Build: staging
- # 7487
- Diff
- Bakual:FixSmartSearchPagination
- Success Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Issue
Pagination doesn't work when you select a "0" value in the SearchTools. In the user manager this is for example "Activated" or the state "Enabled". In the Article Manager this would be the state "Disabled" (btw consistency ftw!).
See #7486 for the original issue
Solution
I tried to fix that originally with #7194 but did a stupid mistake. Of course "0" is a valid filter value, but my boolean check would take that as an invalid value.
This PR fixes it by only threating an empty string (nothing selected) as invalid.
Testing
Test that the pagination the managers with Search Tools work with any values. Also test that it still works in Hathor and modal layouts.
Known issue so far
The "Groups" filter in the user manager still acts wrong. I haven't found yet why that is. maybe someone has an idea.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
Somewhere is the function 'getUserStateFromRequest' called with the wrong key. Key com_users.users.default.filter.group is being called instead of com_users.users.default.filter.group_id.
Thats why the cur_state isn't the same as new_state and that is why the limitstart is set to 0
Haven't found the wrong call yet, someone got a clue where to search?
@LaurensGoedel That was the hint I needed, thanks! Can you try again?
brianteeman
- | Category | ⇒ | Administration |
I have tested this item 
successfully on d667541
Thanks fixes the issue for me.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7487.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Milestone |
Added: |
||
Together with the test by @LaurensGoedel I'm goint to mark this RTC for 3.5.0. Thanks.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7487.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-11-04 10:54:41 |
| Closed_By | ⇒ | Kubik-Rubik |
| Labels |
Removed:
?
|
||
This fixes indeed the state filter.
As described, the group filter isn't working. I'll try to have a look at it later today