? ? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
13 Jul 2015

This is the Pull request for the first part of the work by @rgmears to remove the word manager which is pretty redundant joomla/user-interface-text#42

This PR only looks at the top menu and the quicklinks. The screenshots below show you the before and after.

manager-rgmears-part1

manager-rgmears-part2

avatar brianteeman brianteeman - open - 13 Jul 2015
avatar brianteeman brianteeman - change - 13 Jul 2015
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Jul 2015
Labels Added: ? ?
avatar brianteeman brianteeman - change - 13 Jul 2015
Category Administration Language & Strings UI/UX
avatar brianteeman brianteeman - change - 13 Jul 2015
Easy No Yes
avatar zero-24 zero-24 - change - 13 Jul 2015
Status Pending Ready to Commit
avatar zero-24
zero-24 - comment - 13 Jul 2015

Also this RTC Thanks Brian :smile:


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7431.

avatar zero-24 zero-24 - change - 13 Jul 2015
Labels Added: ?
avatar brianteeman brianteeman - change - 13 Jul 2015
Status Ready to Commit Pending
avatar brianteeman
brianteeman - comment - 13 Jul 2015

Thanks for setting this RTC but I am removing the RTC label as this change needs testing and approval as it changes something that's been this way for over 10 years.


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7431.

avatar MAT978
MAT978 - comment - 13 Jul 2015

successfully tested.

Thanks


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7431.

avatar MAT978 MAT978 - test_item - 13 Jul 2015 - Tested successfully
avatar wilsonge
wilsonge - comment - 14 Jul 2015

Personally this looks a lot better to me. I'll bring it up in the CMS Maintainers Group though for you Brian :)

avatar brianteeman
brianteeman - comment - 14 Jul 2015

If accepted I will make all the extra PR that are needed

avatar rdeutz
rdeutz - comment - 14 Jul 2015

Isn't for Users, Menu and Extension the word Users, Menu and Extension redundant?

Menu -> Manager -> ... makes more sense for me as Menu -> Menu

avatar brianteeman
brianteeman - comment - 14 Jul 2015

Thats an interesting idea. Is this how it is done in german?

On 14 July 2015 at 18:27, Robert Deutz notifications@github.com wrote:

Isn't for Users, Menu and Extension the word Users, Menu and Extension
redundant?

Menu -> Manager -> ... makes more sense for me as Menu -> Menu


Reply to this email directly or view it on GitHub
#7431 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar brianteeman
brianteeman - comment - 14 Jul 2015

And how would it be handled on the quick menu

avatar Bakual
Bakual - comment - 14 Jul 2015

Is this how it is done in german?

In german it's "Menüs" -> "Menüs", "Benutzer" -> "Benutzer" and "Erweiterungen" -> "Erweiterungen".
Looks indeed a bit ugly, especially in the manager itself where you have "Menüs: Menüs" and "Benutzer: Benutzer" as the title.

avatar zero-24 zero-24 - change - 14 Jul 2015
Labels Removed: ?
avatar MAT978
MAT978 - comment - 14 Jul 2015

Agree that having 'Menus : Menu(s)' inside the manager itself is a bit weird but then, what would it be on the Control panel?
"Structure
->Menu(s)"
?

avatar zero-24
zero-24 - comment - 14 Jul 2015

Menu -> Manager ->

Menu -> Manager -> Add New Menu?
Extensions -> Manager?
Users -> Manager -> Add new User?

For the Toolbar it means:
(old) Menu Manager: Menus
(new) Menu: Manager

Extensions (nothing changed)
Extensions: Install

(old) User Manager: Users
(new) User: Manager

Personaly I don't think this is much better.

avatar zero-24
zero-24 - comment - 14 Jul 2015

In german it's "Menüs" -> "Menüs", "Benutzer" -> "Benutzer" and "Erweiterungen" -> "Erweiterungen".
Looks indeed a bit ugly, especially in the manager itself where you have "Menüs: Menüs" and "Benutzer: Benutzer" as the title.

Hmm for sure only these 3. The other components (under the Components Dropdown) don't have this issue ;)

avatar zero-24
zero-24 - comment - 14 Jul 2015

maybe we can remove the manager only particular for

Extensions -> Template Manager
Extensions -> Module Manager
...

And leave for the "Top entrys" like
Extensions -> Extensions Manager
Users --> User Manager
...

avatar rgmears
rgmears - comment - 14 Jul 2015

Menus -> Menu(s)
could be
Menus -> Manage

Users -> Users
could be
Users -> Manage

And Configuration -> Global Configuration
should be
Configuration -> Global

avatar brianteeman
brianteeman - comment - 14 Jul 2015

But what would you do on the quicklinks module?
And when you drill down into the manager page (PR2) what should it then show?

avatar rgmears
rgmears - comment - 14 Jul 2015

Do the same on the Quicklinks module. Except:

Structure
-> Menu(s)
-> Modules

(However I would rather go to Menu Items than Menus from that quick link.)

Not sure what you mean. Drill down? PR2?

avatar wilsonge
wilsonge - comment - 14 Jul 2015

PR2 i think means the second PR part here #7432

avatar brianteeman
brianteeman - comment - 14 Jul 2015

For drill down I mean #7432
If the menu is just Manager what does it say in the list view title

avatar rgmears
rgmears - comment - 15 Jul 2015

Sorry for being so thick here. What is "list view title"?

avatar brianteeman
brianteeman - comment - 15 Jul 2015

This is the view I am referring to.

articles

avatar rgmears
rgmears - comment - 15 Jul 2015

This is how I think it should look.

mgr_menus

mgr_menu_items

avatar brianteeman
brianteeman - comment - 15 Jul 2015

But then you have a menu item called manager that loads a page with the
title menus.

That was the inconsistency I was trying to highlight
On 15 Jul 2015 13:39, "Robert G Mears" notifications@github.com wrote:

This is how I think it should look.

[image: mgr_menus]
https://cloud.githubusercontent.com/assets/4270063/8698500/6f3b0494-2ac4-11e5-8ae4-192e625e5423.png

[image: mgr_menu_items]
https://cloud.githubusercontent.com/assets/4270063/8698504/7b97d56e-2ac4-11e5-8248-0b6e3e4355ea.png


Reply to this email directly or view it on GitHub
#7431 (comment).

avatar rgmears
rgmears - comment - 15 Jul 2015

Where is the menu item "manager" with the page title "menus"?

It might simplify matters to do this:

mgr_structure

Then the Main Menu reflects the organization of the Quick Links menu.

avatar brianteeman
brianteeman - comment - 15 Jul 2015

That was your suggestion several messages up

Menus -> Menu(s)
could be
Menus -> Manage

avatar brianteeman
brianteeman - comment - 15 Jul 2015

As for changing the names of the top level menus and the contents of the
menus I think that is best left to a separate issue
On 15 Jul 2015 14:15, "Brian Teeman" brian@teeman.net wrote:

That was your suggestion several messages up

Menus -> Menu(s)
could be
Menus -> Manage

avatar rgmears
rgmears - comment - 15 Jul 2015

Seemed silly to have Menus -> Menu(s) in the menu.

In this context the Menus page is the same as Categories under Content. Perhaps changing the Menu item to Structure or Navigation (if Modules are left under Extensions) would work. Then you would have
Navigation v
-> Menu(s)
-> Menu Items

avatar rgmears
rgmears - comment - 15 Jul 2015

Alternatively change the title on the Menus page to Manage Menu(s) and everybody's happy.

avatar RCheesley
RCheesley - comment - 16 Jul 2015

There's only one point here which I don't agree with, and that is the change from 'Access Levels' to 'Access'. I think people would better understand what it means to include Access Levels, and I guess when translated that might also make it clearer in other languages.

Everything else I think is an improvement and de-clutters things.

avatar MAT978
MAT978 - comment - 16 Jul 2015

as a non native :p agree with @RCheesley for 'Access Level' & still agree with the originals screen shots from @brianteeman

avatar brianteeman
brianteeman - comment - 16 Jul 2015

I will prepare an updated PR - thanks

On 16 July 2015 at 01:33, Marc-Antoine Thevenet notifications@github.com
wrote:

as a non native :p agree with @RCheesley https://github.com/RCheesley
for 'Access Level' & still agree with the originals screen shots from
@brianteeman https://github.com/brianteeman


Reply to this email directly or view it on GitHub
#7431 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar brianteeman
brianteeman - comment - 19 Jul 2015

Closing this while @rgmears and myself prepare the final complete PR

avatar brianteeman brianteeman - change - 19 Jul 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-07-19 11:15:34
Closed_By brianteeman
avatar brianteeman brianteeman - close - 19 Jul 2015
avatar brianteeman brianteeman - close - 19 Jul 2015
avatar brianteeman brianteeman - head_ref_deleted - 20 Jul 2015

Add a Comment

Login with GitHub to post a comment