Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#7255] - Fix case with string value

? ? Success
Pull Request for # 5763

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
23 Jun 2015

This PR is an updated version of #5763

I finally figured out the reason that the test failed in 5763 was because we were inputting a value for the field as value. This isn't a valid date format for the PHP Datetime class (which JDate extends from), therefore we got an exception.

I've replaced it with two tests - one tests when there is a database null value, and the other for when there is a valid string value (this currently fails)

avatar wilsonge wilsonge - open - 23 Jun 2015
avatar wilsonge wilsonge - change - 23 Jun 2015
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 23 Jun 2015
Labels Added: ?
avatar Fedik
Fedik - comment - 23 Jun 2015

@wilsonge you tried #5611 ... code changes a little bit similar, but purpose different :smile:

avatar wilsonge
wilsonge - comment - 23 Jun 2015

#5611 looks really nice - although I need the change in JHtml::calendar more than the form field (because the two components I'm affected by this with are using FOF :P) but I'm just trying to be consistent across everything.

avatar wilsonge wilsonge - change - 23 Jun 2015
Milestone Added:
avatar wilsonge
wilsonge - comment - 24 Jun 2015

Improved check based on feedback from @Bakual

avatar zero-24 zero-24 - change - 24 Jun 2015
Category ⇒ Libraries
avatar zero-24 zero-24 - change - 24 Jun 2015
Rel_Number 0 ⇒ 5763
Relation Type ⇒ Pull Request for
avatar dgt41
dgt41 - comment - 26 Jun 2015

@test OK calendar still operates as usual

avatar zero-24 zero-24 - alter_testresult - 26 Jun 2015 - dgt41: Tested successfully
avatar zero-24 zero-24 - test_item - 26 Jun 2015 - Tested successfully
avatar zero-24 zero-24 - change - 26 Jun 2015
Status Pending ⇒ Ready to Commit
Easy No ⇒ Yes
avatar zero-24
zero-24 - comment - 26 Jun 2015

The calendar still works as expected (com_content).

RTC :smile:

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/7255.

avatar zero-24 zero-24 - change - 26 Jun 2015
Labels Added: ?
avatar rdeutz rdeutz - change - 28 Jun 2015
Milestone Added:
avatar rdeutz rdeutz - change - 28 Jun 2015
Milestone Removed:
avatar zero-24 zero-24 - change - 2 Jul 2015
Milestone Removed:
avatar zero-24 zero-24 - change - 2 Jul 2015
Milestone Removed:
avatar zero-24 zero-24 - change - 2 Jul 2015
Milestone Added:
avatar zero-24 zero-24 - change - 2 Jul 2015
Milestone Added:
avatar zero-24 zero-24 - close - 3 Jul 2015
avatar wilsonge wilsonge - close - 3 Jul 2015
avatar wilsonge wilsonge - change - 3 Jul 2015
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-07-03 10:21:07
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 3 Jul 2015
avatar Kubik-Rubik
Kubik-Rubik - comment - 3 Jul 2015

Thank you @wilsonge! Merged.

avatar wilsonge wilsonge - head_ref_deleted - 3 Jul 2015
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?
avatar joomla-cms-bot joomla-cms-bot - change - 14 Oct 2015
Labels Added: ?

Add a Comment

Login with GitHub to post a comment