Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#5763] - Remove int typehint

? Failure
Referenced as Pull Request for: # 7255

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
16 Jan 2015

This was intially checking a null date until @Bakual 's changes. However now there is no reason for it. This can cause bugs when you don't have a fully integer date (e.g. display a month in full which is perfectly compatible with strtotime() http://php.net/manual/en/datetime.formats.date.php)

To test check the calendar still works as expected

If you want to go the extra mile you can add a format like %B %Y into the calendar. This will save correctly but not render. Apply patch and it should be fixed.

avatar wilsonge wilsonge - open - 16 Jan 2015
avatar jissues-bot jissues-bot - change - 16 Jan 2015
Labels Added: ?
avatar wilsonge wilsonge - change - 16 Jan 2015
The description was changed
0a4f2bf 16 Jan 2015 avatar wilsonge Oops
avatar zero-24 zero-24 - change - 16 Jan 2015
Category ⇒ Libraries
avatar zero-24 zero-24 - change - 16 Jan 2015
Easy No ⇒ Yes
avatar zero-24
zero-24 - comment - 16 Jan 2015

@wilsonge

travis is not happy with that change see:


There was 1 error:
1) JFormFieldCalendarTest::testGetInput
Exception: DateTime::__construct(): Failed to parse time string (value) at position 0 (v): The timezone could not be found in the database
/home/travis/build/joomla/joomla-cms/libraries/joomla/date/date.php:106
/home/travis/build/joomla/joomla-cms/libraries/joomla/factory.php:530
/home/travis/build/joomla/joomla-cms/libraries/joomla/form/fields/calendar.php:197
/home/travis/build/joomla/joomla-cms/libraries/joomla/form/field.php:393
/home/travis/build/joomla/joomla-cms/libraries/joomla/form/fields/calendar.php:73
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/joomla/form/fields/JFormFieldCalendarTest.php:523

FAILURES!                                                              
Tests: 5700, Assertions: 10446, Errors: 1, Incomplete: 9, Skipped: 127.
`` `
https://travis-ci.org/joomla/joomla-cms/jobs/47277702<hr /><sub>This comment was created with the <a href="https://github.com/joomla/jissues">J!Tracker Application</a> at <a href="http://issues.joomla.org/tracker/joomla-cms/5763">issues.joomla.org/joomla-cms/5763</a>.</sub>
avatar zero-24 zero-24 - change - 16 Jan 2015
Easy Yes ⇒ No
avatar wilsonge wilsonge - close - 3 Feb 2015
avatar wilsonge wilsonge - close - 3 Feb 2015
avatar wilsonge wilsonge - change - 3 Feb 2015
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-02-03 17:26:02
avatar wilsonge wilsonge - head_ref_deleted - 3 Feb 2015

Add a Comment

Login with GitHub to post a comment