? Success

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
20 Mar 2015

The check that is removed in this PR was not valid since Joomla 1.6 and there is no way to install an editor in a way that this check would have evaluated to true. So this might as well be removed here and now.

avatar Hackwar Hackwar - open - 20 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 20 Mar 2015
Labels Added: ?
avatar brianteeman
brianteeman - comment - 20 Mar 2015

Applied patch and was still able to install JCE - is that a successful test?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6513.
avatar joomdonation
joomdonation - comment - 21 Mar 2015

@brianteeman Make sure the editor is still being loaded properly (when you edit an article for example) and your test could be counted as one successful test.

@test : Look good from code review. Also applied the patch and editor still being loaded properly. So test success from me.

avatar Hackwar
Hackwar - comment - 21 Mar 2015

@brianteeman as @joomdonation said, this is during loading of an editor. This check came from a time where plugins did not have their own folder, but were installed in the plugin groups folder directly. That is not possible anymore since 1.6 and thus this check can be removed.

avatar infograf768
infograf768 - comment - 21 Mar 2015

Agree.

avatar brianteeman brianteeman - alter_testresult - 21 Mar 2015 - joomdonation: Tested successfully
avatar brianteeman brianteeman - test_item - 21 Mar 2015 - Tested successfully
avatar brianteeman
brianteeman - comment - 21 Mar 2015

Setting RTC


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6513.
avatar brianteeman brianteeman - change - 21 Mar 2015
Status Pending Ready to Commit
avatar brianteeman brianteeman - change - 21 Mar 2015
Labels Added: ?
avatar wilsonge wilsonge - change - 21 Mar 2015
Milestone Added:
avatar zero-24 zero-24 - change - 22 Mar 2015
Category Libraries
avatar wilsonge wilsonge - change - 13 Apr 2015
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2015-04-13 15:03:17
avatar wilsonge wilsonge - close - 13 Apr 2015
avatar wilsonge wilsonge - reference | - 13 Apr 15
avatar wilsonge wilsonge - merge - 13 Apr 2015
avatar wilsonge wilsonge - close - 13 Apr 2015
avatar zero-24 zero-24 - close - 13 Apr 2015
avatar wilsonge wilsonge - change - 13 Apr 2015
Milestone Added:
avatar wilsonge wilsonge - change - 13 Apr 2015
Milestone Removed:
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?
avatar Hackwar Hackwar - head_ref_deleted - 6 Jan 2016

Add a Comment

Login with GitHub to post a comment