[#6512] - Fix up the 'core' javascript file
- Closed
- 9 Jul 2015
- Medium
- Build: staging
- Easy Test
- # 6512
- Diff
- okonomiyaki3000:fix-core-problems
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This is the follow up to this here: #6509
Define the Joomla 'core' function inside of a strict closure, fix all the ensuing problems.
- missing semicolons: fixed
- undeclared variables: fixed
- nonsense code: sort of fixed
Testing
These functions are used all over the place and, since the file was not in strict mode before, the mistakes in it were not apparent anyway. So the best way to test is to first try #6509 and see where it goes wrong. There is usually a comment above each function to tell where it is used. These are generally reliable.
There are certainly several functions which are no longer used at all and some which are specifically deprecated. There is some chance that a 3rd party is using them but there should be a plan for removing all the junk.
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
| Title |
|
||||||
| Rel_Number | ⇒ | 6509 | |
| Relation Type | ⇒ | Related to |
| Easy | No | ⇒ | Yes |
| Category | ⇒ | JavaScript |
Uh. Great. These errors have nothing to do with any of these changes. Thanks, Travis.
It seems that FOFPlatform (whatever it is) does not implement the method logAddLogger which it is supposed to do. So this causes Travis to fail. Please note that FOFPlatform has nothing to do with the core javascript file which is the only thing modified by this PR.
test works good for me
These errors have nothing to do with any of these changes. Thanks, Travis.
Travis recently sometimes stalls because it takes to long to fetch the dependencies with composer.
I've restarted the failing job, hopefully it will pass now.
#TEST OK
Nice to have a cleaner Javascript implementation.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6512.
| Status | Pending | ⇒ | Ready to Commit |
RTC Thanks 
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6512.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-07-09 08:44:26 |
| Closed_By | ⇒ | Kubik-Rubik |
Thank you @okonomiyaki3000. I've fixed the conflicts and merged the PR.
@Kubik-Rubik I think this merge cause this issue: http://issues.joomla.org/tracker/joomla-cms/7388
@javigomez Thank you, we have to check it.
@okonomiyaki3000 @Fedik @anibalsanchez Could you also take a look?
yes, need some time, and I will make a pull ... if no one will make it faster
@Kubik-Rubik there it is #7391
@Fedik Wow, that was fast. Thank you, I will check it soon. @javigomez Could you please test this PR #7391 by Fedik?
@Fedik @Kubik-Rubik Thanks!
| Labels |
Removed:
?
|
||
@okonomiyaki3000 please check the
core.js, there was some changes toJoomla.submitform, and maybe some other ... that cause the merge conflict