[#6444] - UX: Additional Buttons during the installation #6422
- Closed
- 10 Oct 2015
- Medium
- Build: staging
- # 6444
- Diff
- joomla-agency:staging
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Issue: #6422
Additional Next/Back Buttons in the bottom of the page, during the Joomla 3.4.x installation.
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Labels |
Added:
?
|
||
brianteeman
- | Rel_Number | 0 | ⇒ | 6422 |
| Relation Type | ⇒ | Pull Request for |
| Category | ⇒ | Installation UI/UX |
Please test this first with an RTL language.
RTL (Persian) Screenshot
the issue is that text-right has no RTL equivalent.
Therefore we get:
I would change instances of text-right to pull-right
@infograf768 i think, for a RTL Reader is the new right button position an excepted one.
If the purpose of the PR is to present the same buttons on top and bottom, then RTL or LTR should be treated equally. Until now we have always mirrored RTL button positions in all Joomla.
That's only my 2 cents.
@infograf768 You're absolutly right. My bad.
Ok. I change the Pull Request.
@joomla-agency
Please do.
@infograf768 done! Can someone test this again for LTR / RTL Support and all views?
Two screenshots for LTR and RTL
@roland-d @joomla-agency branch is broken - maybe there is a way to restore?
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6444.
@designbengel @joomla-agency I never recovered a deleted branch but StackOverflow tells us this:
Yes, you should be able to do git reflog and find the SHA1 for the commit at the tip of your deleted branch, then just git checkout [sha]. And once you're at that commit, you can just git checkout -b [branchname] to recreate the branch from there.
http://stackoverflow.com/questions/3640764/can-i-recover-branch-after-its-deletion-in-git
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-10 11:49:54 |
| Closed_By | ⇒ | zero-24 |
+1
No error, no b/c issues, better usability.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6444.