[#6443] - Add tests for JLanguageMultilang
- Closed
- 17 Mar 2015
- Medium
- Build: staging
- # 6443
- Diff
- wilsonge:multilangtest
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
There is a small change to allow the application object to be injected in to allow unit tests this can be tested easily by just navigating around Joomla.
Finally as per the doc block I've typecast the result to be a boolean as it was returning the string 0 on false and 1 on true for the enabled state of the plugin (as these are the values stored in the database). Currently you get true and false in the frontend and 0 and 1 in the backend.
Testing
All the routing in the frontend depends on this class so navigate around and ensure that with plugin enabled and disabled everything works as expected.
In the backend ensure that the modal views when you are selecting a single item in the menu show everything properly
joomla-cms-bot
- | Labels |
Added:
?
|
||
zero-24
- | Category | ⇒ | Unit Tests |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-17 21:42:19 |
Looks good. This test brings up 2 issues for me: JLanguageMultilang couples a multi-lang implementation to our language filter plugin and it shows that our language implementation is pretty hacked together... This class is pretty much just bloat. A proper implementation would read that from some general storage and a proper languagefilter implementation would set that flag regardless of the app that is currently running.