Success

Success The Travis CI build passed Details

Pull Request for # 5976

User tests: Successful: Unsuccessful:

Harmageddon
12 Mar 2015

This PR changes the order of declarations to fix #5976 + some small code style changes (I moved the usage of $('...') selectors to singular variable declarations).

Testing instructions

Enable the debug console in backend (System configuration - Debug System).
Navigate to a page in the backend, where the sidebar is longer than the page content (e.g. Extensions - Languages - Overrides if you don't have overrides or Content - Articles with a filter set), so it is next to the debug console.
- Make sure that the sidebar is displayed correctly and doesn't overlap the debug console or something else.
- Close and re-open the sidebar to make sure it behaves correctly.
Do the same for a page with more content (e.g. articles or extensions).

ca6b969 12 Mar 2015

Fix sidebar issue with debug console #5976

Harmageddon - open - 12 Mar 2015

joomla-cms-bot - change - 12 Mar 2015

Labels

Added: ?

Harmageddon - change - 12 Mar 2015

Rel_Number		⇒	5976
Relation Type		⇒	Pull Request for

n9iels - comment - 12 Mar 2015

@test successful, the patch solves the bug

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6401.}

n9iels - test_item - 12 Mar 2015 - Tested successfully

sovainfo - test_item - 12 Mar 2015 - Tested successfully

102e69c 12 Mar 2015

Fixed wrong order, thanks @JoomIIC!

098ffd2 12 Mar 2015

Codestyle

JoomliC - test_item - 12 Mar 2015 - Tested unsuccessfully

JoomliC - comment - 12 Mar 2015

Test failed.

You are introducing back a previous bug which was fixed by @dgt41 : #5917

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6401.}

sovainfo - comment - 12 Mar 2015

Cant confirm that:

Harmageddon - comment - 12 Mar 2015

@JoomliC Thank you, good observation! I accidently switched the order of two code blocks. Should be fixed now.

JoomliC - comment - 12 Mar 2015

@sovainfo J3.4.0 with this PR applied (firefox, macbook) ;-)

JoomliC - comment - 12 Mar 2015

@Harmageddon Test ok now

Just, maybe use the Joomla code styles for javascript here : http://joomla.github.io/coding-standards/?coding-standards/chapters/javascript.md

Mainly for multiple variable declarations.
(i didn't use those standards in initial sidebar PR (now i know!), so maybe it's better to follow the standards in core and this way edit my error in standard coding style ;-) )

JoomliC - test_item - 12 Mar 2015 - Tested successfully

c14b064 12 Mar 2015

Coding standards v2

Harmageddon - comment - 12 Mar 2015

@JoomliC Done, thanks!

sovainfo - comment - 12 Mar 2015

Still leaves variable names to be camelcase instead of using '_'.

JoomliC - comment - 12 Mar 2015

@sovainfo You're right, naming convention of variable camelCase