[#6400] - Checking if the lang_code was already set in POST
- Closed
- 16 Mar 2015
- Medium
- Build: staging
- Easy Test
- # 6400
- Diff
- Hackwar:patch-42
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
If Joomla is requested via POST, we might have already a language defined via the URL and thus don't need to fall back on the cookie value.
Example:
Request via POST to "index.php" => No language given, falling back to cookie or default language
Request via POST to "index.php?lang=en" => Language given, no need to fall back to something else
Request via POST to "/en/component/content/42" => Language given, no need to fall back to something else
Without this path, the last 2 examples will fall back to the default language.
| Easy | No | ⇒ | Yes |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Plugins Router / SEF |
| Status | Pending | ⇒ | Ready to Commit |
brianteeman
- 
kolvar
- 
RTC based on testing by @aruttkamp and @kolvar Thanks
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6400.
let's wait the cookie issue is solved to look at this one again.
Why? Should we stop looking at issues in JForm, too, because of the cookie issue? Those 2 are completely different topics.
they may be, but it is likely that the languagefilter code will be changed in an important way to solve the cookie issue. Therefore this would have, if still necessary, to be adapted.
What I wonder is if the whole if clause makes sense. The comment says we don't care about language, but we actually do care now. Or am I wrong?
The comment might have to be adapted.
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-16 14:14:41 |
The $lang_code could be not initialised in your check yet.
So shouldn't it be:
if (!isset($lang_code))
tested - ok
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6400.