Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#6278] - Remove usage of JRouter from Languagefilter Plugin constructor

? Success
Referenced as Not before: # 6254

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
3 Mar 2015

In light of the issues that Falang had recently, this PR removes the usage of the router from the constructor, thus giving plugins like Falangs the chance to do their thing.

avatar Hackwar Hackwar - open - 3 Mar 2015
avatar joomla-cms-bot joomla-cms-bot - change - 3 Mar 2015
Labels Added: ?
avatar mbabker
mbabker - comment - 3 Mar 2015

In truth, I think we need to remove the dependency on the language filter plugin from JApplicationSite::initialiseApp(). This constructor is triggered long before the rest of the system plugins are imported for the onAfterInitialise event and I'm not seeing anything in the plugin that makes this dependency a requirement.

avatar Hackwar
Hackwar - comment - 3 Mar 2015

@mbabker not anymore. This was made possible by #5140. I didn't know that there was this special code in JApplicationSite to do this. But that wont change the issue, just make it harder to detect. So this PR is a good step forward.

avatar infograf768
infograf768 - comment - 4 Mar 2015

Notice: Use of undefined constant JROUTER_MODE_SEF - assumed 'JROUTER_MODE_SEF' in /plugins/system/languagefilter/languagefilter.php on line 58

avatar Hackwar
Hackwar - comment - 4 Mar 2015

Fixed.

avatar zero-24 zero-24 - change - 7 Mar 2015
Category ⇒ Multilanguage Plugins Router / SEF
avatar gwsdesk
gwsdesk - comment - 8 Mar 2015

@test Tested on a site with Falang and wrorks4me. Thanks Hannes

avatar zero-24 zero-24 - alter_testresult - 8 Mar 2015 - gwsdesk: Not tested
avatar zero-24 zero-24 - alter_testresult - 8 Mar 2015 - gwsdesk: Tested successfully
avatar infograf768 infograf768 - change - 9 Mar 2015
Labels Added: ?
avatar infograf768 infograf768 - change - 9 Mar 2015
Milestone Added:
avatar wilsonge wilsonge - close - 9 Mar 2015
avatar wilsonge wilsonge - reference | fd5eb39 - 9 Mar 15
avatar wilsonge wilsonge - merge - 9 Mar 2015
avatar wilsonge wilsonge - close - 9 Mar 2015
avatar zero-24 zero-24 - close - 9 Mar 2015
avatar wilsonge wilsonge - change - 9 Mar 2015
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2015-03-09 12:13:12
avatar zero-24 zero-24 - change - 14 Oct 2015
Labels Removed: ?
avatar Hackwar Hackwar - head_ref_deleted - 6 Jan 2016

Add a Comment

Login with GitHub to post a comment