@Hackwar Travis fail?

There was 1 failure:
1) JRouterSiteTest::testProcessBuildRules with data set #1 ('index.php?Itemid=42&test=true', 0, 'index.php?option=com_test&vie...mid=42')
JRouterSiteTest::testProcessBuildRules:699: value is not expected
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'index.php?Itemid=42&test=true'
+'index.php?option=com_test&view=test&Itemid=42'
/home/travis/build/joomla/joomla-cms/tests/unit/suites/libraries/cms/router/JRouterSiteTest.php:699b

https://travis-ci.org/joomla/joomla-cms/jobs/52708560

Yes, that is more or less expected. I wrote the unittests after the actual code and since that code was not correct, the unittests are not correct either.

Or rather, this shows bugs in the old code right now. There is more necessary than moving that part of the code a bit earlier.

@test fails here
This creates other issues with the language switcher, SEF OFF.

A Classic menu item alias to the Home Page (Featured view) on top menu gives:
index.php?option=com_content&view=featured&Itemid=153&lang=it (instead of index.php?lang=it)
then when one wants to change language to display the home in another language by clicking on the flag, one gets for FR:
/index.php?lang=fr&Itemid=102&option=com_content

@test
We now have correct full links also through the language switcher, but still not a simple:
index.php?lang=en for the Home page

@test
When I apply this patch with patch tester, I get that: "Fatal error: Call to a member function getMode() on a non-object in /home/www/sitestests/multi/plugins/system/languagefilter/languagefilter.php on line 59"

@fontanil
Try to also apply #6278

@test
Fine! both 6254 and 6278 patches solve language switcher URLs and language in Virtuemart popup.
Thanks!

Moving to RTC here and set the relation to #6278