Joomla! Issue Tracker | Joomla! CMS #6035 - Fix wrong filtering in JInput::getArray()

Closed
10 Apr 2015
Medium
Build: staging
# 6035
Diff
Erftralle:fix-jinput-getarray

Success

Success continuous-integration/travis-ci The Travis CI build passed Details

Pull Request for # 6008

User tests: Successful: Unsuccessful:

Erftralle
10 Feb 2015

This is a pull request for issue #6008.
It fixes the applying of wrong filters in the case, that the function is called without parameters.

If using the JInput::getArray() function without parameters e.g.

        $mypostdata = $myapp->input->post->getArray();

and the post data contains variables having values matching a JInputFilter type e.g. 'integer', 'int', 'float' etc. these values will be applied as filter in the following function code:

                if (is_null($datasource))
                {
                    $results[$k] = $this->get($k, null, $v);
                }

When calling the function without parameters the function uses the class property 'data', which is an associative array with variable names and their values.

So, a POST variable 'myinputstring' containing a string value 'integer' will be returned as an integer containing a 0, which is definetly a wrong behaviour.

Wouldn't it be better to detect a parameterless function call to apply 'RAW' filters in that case?

34721e4 10 Feb 2015

Fix wrong filtering in JInput::getArray()

Erftralle - open - 10 Feb 2015

joomla-cms-bot - change - 10 Feb 2015

Labels

Added: ?

be116dd 10 Feb 2015

Fix Travis CI

zero-24 - change - 12 Feb 2015

Test instructions

Please install Joomla-3.2-Hello-World-Component Step 10, create a menu item and append the following code lines to the file components/com_helloworld/views/helloworld/tmpl/default.php:

<h4>The following test code is executed to demonstrate the bug in JInput::getArray():</h4>
<pre>
JFactory::getApplication()->input->set('my-input-string', 'integer');
$this->testdata = JFactory::getApplication()->input->getArray();
</pre>
<?php JFactory::getApplication()->input->set('my-input-string', 'integer');
      $this->testdata = JFactory::getApplication()->input->getArray(); ?>
<p>The variable <b>type</b> of <code>$this->testdata['my-input-string']</code> is <b><?php echo gettype($this->testdata['my-input-string'])?></b> (... it should be <b>string</b>)</p>
<p>The variable <b>value</b> of <code>$this->testdata['my-input-string']</code> is <b><?php echo $this->testdata['my-input-string']?></b> (... it should be the string <b>&#39;integer&#39;</b>)</p>

Compare the output for the variable type and value before and after applying the patch.

RickR2H - comment - 10 Apr 2015

Easy to test and the fix inconfirmed!

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6035.}

RickR2H - test_item - 10 Apr 2015 - Tested successfully

hvdmeer - comment - 10 Apr 2015

@test Tested and output as described.

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6035.}

zero-24 - change - 10 Apr 2015

Status

Pending

⇒

Ready to Commit

hvdmeer - test_item - 10 Apr 2015 - Tested successfully

zero-24 - comment - 10 Apr 2015

RTC based on testing. Thanks!

_{This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6035.}

zero-24 - change - 10 Apr 2015

Labels

Added: ?

roland-d - change - 10 Apr 2015

Status	Ready to Commit	⇒	Closed
Closed_Date	0000-00-00 00:00:00	⇒	2015-04-10 15:15:49

roland-d - close - 10 Apr 2015

zero-24 - close - 10 Apr 2015

Erftralle - comment - 10 Apr 2015

@RickR2H @hvdmeer Thanks a lot for testing.

@zero-24 I just wanted to add the version number to the documentation block of the new function but the fix has already been merged by @roland-d . I don't know what to do know, please advise me. Thanks.