[#6034] - Optimizing mod_login helper
- Closed
- 15 Mar 2015
- Medium
- Build: staging
- Easy Test
- # 6034
- Diff
- Hackwar:patch-28
- Success The Travis CI build passed Details
User tests: Successful: Unsuccessful:
We already have loaded all menu items. We don't need to look up an existing menu item again. If JMenu does not return this item, it either does not exist or it is unpublished or not accessible for the user. The router also makes sure that all parameters of a menu item are correctly stripped. There is no need to differentiate between SEF and non-SEF URLs.
How to test
- See current behavior of mod_login
- Apply patch
- Notice that performance improves and nothing else changes.
joomla-cms-bot
- | Labels |
Added:
?
|
||
@810 what were you doing to get that error. I couldnt replicate it myself
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6034.
@brianteeman i applied patch with patchtester, on a ssl website.
@test
With patch:
Without patch:
Strange as I cannot get that error message (perhaps because I am not on an
SSL site?)
On 9 February 2015 at 23:37, Jelle Kok notifications@github.com wrote:
@brianteeman https://github.com/brianteeman i applied patch with
patchtester, on a ssl website.@test https://github.com/test
With patch:
[image: with]
https://cloud.githubusercontent.com/assets/876623/6118345/dcabcf86-b0bc-11e4-8d0d-5c675272b35e.jpg
Without patch:
[image: without]
https://cloud.githubusercontent.com/assets/876623/6118354/eeb68bbc-b0bc-11e4-991e-28baf24f7f33.jpg—
Reply to this email directly or view it on GitHub
#6034 (comment).
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/
| Easy | No | ⇒ | Yes |
| Category | ⇒ | Front End Modules |
Indeed, nothing changes but the performance does not get much better either
It is 50 lines of code less. Yes, the performance improvement is negligible.
Works normal :-)
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6034.
| Status | Pending | ⇒ | Ready to Commit |
RTC thanks for testing!
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/6034.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-03-15 09:27:48 |
Merged. Thanks!
| Labels |
Removed:
?
|
||
Fatal error: Class 'ModLoginHelper' not found in /home//domains//public_html/modules/mod_login/mod_login.php on line 17
j3.4 b2
Mhh other patches same issues, maybe my test site is broken.