? Success
Referenced as Related to: # 4775

User tests: Successful: Unsuccessful:

avatar rbsl-rimjhim
rbsl-rimjhim
17 Oct 2014

mediamanager

Votes

# of Users Experiencing Issue
3/4
Average Importance Score
2.50

avatar rbsl-rimjhim rbsl-rimjhim - open - 17 Oct 2014
avatar jissues-bot jissues-bot - change - 17 Oct 2014
Labels Added: ?
avatar superfoght superfoght - test_item - 17 Oct 2014 - Tested successfully
avatar superfoght
superfoght - comment - 17 Oct 2014

Confirmed. I get a message now :) http://screencast.com/t/XJGLzlTVj

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4777.

avatar hanshenrikchr hanshenrikchr - test_item - 17 Oct 2014 - Tested successfully
avatar 1apweb 1apweb - test_item - 17 Oct 2014 - Tested successfully
avatar dimitargsg dimitargsg - test_item - 17 Oct 2014 - Tested successfully
avatar dimitargsg
dimitargsg - comment - 17 Oct 2014

@test Tested this successfully.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4777.

avatar deepanshu-jha
deepanshu-jha - comment - 17 Oct 2014

The issue is related to the usage of JToolBar::appendButton() function in com_media as there is no such boolean parameter available(true or false) which if passed can generate an alert box asking for making a selection from the list. Where as in case of other pre-defined JToolBar buttons, like publish , unpublish etc. the alert popup can be easily implemented by simply passing the boolean parameter.

The important point in this case which needs to be enlightened is that the delete button in this issue is not the pre-defined JToolbarHelper::deleteList(); but it is a custom JToolBar::appendButton(); button. So, the work around for this would be customizing the javascript code in the component but not in the library files.I am working on it.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4777.

avatar jissues-bot jissues-bot - change - 17 Oct 2014
Title
Media Manager-validation required on delete button #4775
Media Manager-validation required on delete button
avatar brianteeman brianteeman - change - 17 Oct 2014
The description was changed
Title
Media Manager-validation required on delete button #4775
Media Manager-validation required on delete button
avatar brianteeman brianteeman - change - 17 Oct 2014
Category Media Manager
avatar brianteeman
brianteeman - comment - 17 Oct 2014

Based on the last comment I am setting this one as Needs Review by maintainers

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4777.

avatar brianteeman brianteeman - change - 17 Oct 2014
Status Pending Needs Review
avatar twssachin twssachin - test_item - 18 Oct 2014 - Tested successfully
avatar durgesh4 durgesh4 - test_item - 18 Oct 2014 - Tested successfully
avatar vijaykhollam vijaykhollam - test_item - 18 Oct 2014 - Tested successfully
avatar orware
orware - comment - 18 Oct 2014

The solution for this one seems to be ok (and I was able to test it successfully as well).

The current Travis CI build failure being shown on the Pull Request page for this one seems to be unrelated to the actual patch itself.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4777.

avatar sparkosis23 sparkosis23 - test_item - 8 Nov 2014 - Tested successfully
avatar sparkosis23
sparkosis23 - comment - 8 Nov 2014

I was able to reproduce the bug: in Media Manager, click the Delete button with nothing selected. It reloads like it's doing something with no error or confirmation of what happened. After applying the patch, tested again and clicking Delete button without anything selected results in error box "Please first make a selection from the list". Bug fixed.

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4777.

avatar Hackwar
Hackwar - comment - 3 Feb 2015

There is an error in the unittests with your changes. Please see if you can fix those.

avatar mdemop mdemop - test_item - 19 Jul 2015 - Tested successfully
avatar wilsonge wilsonge - change - 12 Apr 2016
Status Needs Review Pending
Easy No Yes
avatar wilsonge
wilsonge - comment - 12 Apr 2016

I can't see anything wrong with this - removing from needs review. Can I have one test here to confirm the patch is still required and works as expected before it goes RTC please?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4777.

avatar brianteeman
brianteeman - comment - 12 Apr 2016

@wilsonge is the comment about unit tests no longer valid either?


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4777.

avatar wilsonge
wilsonge - comment - 12 Apr 2016

I don't think so. There are no unit tests failing with this and there are none covering this kinda stuff anyhow. I think Dmitris will throw a small hissy fit about using script tags rather than using JDocument but given the age of this PR i"d rather merge this if it works and then get him to do that separately

avatar MATsxm
MATsxm - comment - 12 Apr 2016

success with BEFORE:
screen shot 2016-04-12 at 18 15 51

then AFTER:
screen shot 2016-04-12 at 18 16 19


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4777.

avatar MATsxm MATsxm - test_item - 12 Apr 2016 - Tested successfully
avatar MATsxm
MATsxm - comment - 12 Apr 2016

I have tested this item :white_check_mark: successfully on 97f89dc


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4777.

avatar brianteeman brianteeman - test_item - 13 Apr 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 13 Apr 2016

I have tested this item :white_check_mark: successfully on 97f89dc

For consistency this is correct.

Personally this type of functionality should be labelled "you are an idiot why did you click without selecting"


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4777.

avatar brianteeman brianteeman - change - 13 Apr 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 13 Apr 2016

RTC
Not a new feature as this functionality is present everywhere else so setting 3.5.2 milestone


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4777.

avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 13 Apr 2016
Milestone Added:
avatar rdeutz
rdeutz - comment - 13 Apr 2016

@rbsl-rimjhim could you check the merge conflicts, thanks

avatar wilsonge
wilsonge - comment - 13 Apr 2016

Robert as this PR is 18 months old think this is one of those cases where we can do it ourselves ;)

avatar rdeutz
rdeutz - comment - 13 Apr 2016

Feel free to do it :-P

avatar brianteeman
brianteeman - comment - 13 Apr 2016

I will do it now

avatar brianteeman brianteeman - change - 13 Apr 2016
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2016-04-13 11:21:31
Closed_By brianteeman
Labels
avatar brianteeman brianteeman - change - 13 Apr 2016
Labels
avatar brianteeman brianteeman - close - 13 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - reopen - 13 Apr 2016
avatar brianteeman brianteeman - close - 13 Apr 2016
avatar brianteeman
brianteeman - comment - 13 Apr 2016

See #9891


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4777.

avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2016
Status Closed New
Closed_Date 2016-04-13 11:21:31
Closed_By brianteeman
avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - reopen - 13 Apr 2016
avatar joomla-cms-bot joomla-cms-bot - change - 13 Apr 2016
Labels Removed: ?
avatar wilsonge wilsonge - close - 13 Apr 2016
avatar wilsonge
wilsonge - comment - 13 Apr 2016

Merged #9891

avatar wilsonge wilsonge - change - 13 Apr 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-04-13 11:29:40
Closed_By wilsonge
avatar wilsonge wilsonge - close - 13 Apr 2016
avatar rdeutz rdeutz - change - 1 May 2016
Milestone
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone Added:
avatar rdeutz rdeutz - change - 1 May 2016
Milestone

Add a Comment

Login with GitHub to post a comment