Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#4776] - This fixes #4763 where adding space created duplicate viewlevels

? Success
Related to # 4673
Referenced as Related to: # 4763

User tests: Successful: Unsuccessful:

avatar aDaneInSpain
aDaneInSpain
17 Oct 2014

.#### Steps to reproduce the issue
1. Go to Users->Access levels.
2. Click on add button to create new record.
3. Enter space as chacter and existing level name.
4. Save the record.

Expected result

Duplicate access levels should not be added.

Actual result

Duplicate access levels are added successfully.screen shot 2014-10-17 at 06 33 26

System information (as much as possible)

PHP Built On Windows NT 6.2 build 9200
Database Version 5.6.12-log
Database Collation utf8_general_ci
PHP Version 5.4.12
Web Server Apache/2.4.4 (Win64) PHP/5.4.12
WebServer to PHP Interface apache2handler
Joomla! Version Joomla! 3.3.7-dev Development [ Ember ] 01-October-2014 02:00 GMT
Joomla! Platform Version Joomla Platform 13.1.0 Stable [ Curiosity ] 24-Apr-2013 00:00 GMT
User Agent Mozilla/5.0 (Windows NT 6.1; rv:32.0) Gecko/20100101 Firefox/32.0

Additional comments

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00
avatar aDaneInSpain aDaneInSpain - open - 17 Oct 2014
avatar jissues-bot jissues-bot - change - 17 Oct 2014
Labels Added: ?
avatar jespersoelundhansen jespersoelundhansen - test_item - 17 Oct 2014 - Tested successfully
avatar hanshenrikchr
hanshenrikchr - comment - 17 Oct 2014

i just tested this and it works indeed with your patch

This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4776.

avatar hanshenrikchr hanshenrikchr - test_item - 17 Oct 2014 - Tested successfully
avatar brianteeman brianteeman - change - 17 Oct 2014
The description was changed
Rel_Number ⇒ 4673
Relation Type ⇒ Related to
avatar brianteeman brianteeman - change - 17 Oct 2014
The description was changed
Title
…
This fixes #4763 where adding space created duplicates
This fixes #4763 where adding space created duplicate users
avatar jissues-bot jissues-bot - change - 17 Oct 2014
Title
…
This fixes #4763 where adding space created duplicates
This fixes #4763 where adding space created duplicate users
avatar veerendratasol veerendratasol - test_item - 17 Oct 2014 - Tested successfully
avatar gunjanpatel gunjanpatel - change - 17 Oct 2014
Status Pending ⇒ Ready to Commit
avatar gunjanpatel
gunjanpatel - comment - 17 Oct 2014

We have more than 2 successful test, moving to RTC .

avatar brianteeman brianteeman - change - 17 Oct 2014
Category ⇒ Authentication
avatar infograf768
infograf768 - comment - 19 Oct 2014

FILE: ...d/joomla/joomla-cms/administrator/components/com_users/models/level.php

FOUND 1 ERROR(S) AFFECTING 1 LINE(S)

216 | ERROR | Whitespace found at end of line

avatar infograf768
infograf768 - comment - 19 Oct 2014

Also, I suggest to use, instead of trim() the new filter which takes also care of multibytes spaces (Asian space), i.e
instead of

+       
+       $data['title'] = trim($data['title']);

use

+       
+       $data['title'] = JFilterInput::getInstance()->clean($data['title'], 'TRIM');

To test here is a multibyte space between both multi
multi　multi

avatar jissues-bot jissues-bot - change - 19 Oct 2014
Labels Added: ?
avatar infograf768 infograf768 - change - 20 Oct 2014
Milestone
avatar infograf768 infograf768 - reference | fb96409 - 20 Oct 14
avatar infograf768 infograf768 - merge - 20 Oct 2014
avatar infograf768 infograf768 - close - 20 Oct 2014
avatar infograf768 infograf768 - close - 20 Oct 2014
avatar infograf768 infograf768 - change - 20 Oct 2014
Status Ready to Commit ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2014-10-20 07:26:20
avatar infograf768
infograf768 - comment - 20 Oct 2014

Thanks!

avatar aDaneInSpain aDaneInSpain - head_ref_deleted - 20 Oct 2014
avatar zero-24
zero-24 - comment - 20 Oct 2014

@aDaneInSpain @infograf768 Do you think we should backport it to 2.5.x?

avatar infograf768
infograf768 - comment - 20 Oct 2014

The new filtering method does not exist in 2.5.x, so we should use trim().
Also see:
#4858

avatar infograf768 infograf768 - change - 20 Oct 2014
Title
…
This fixes #4763 where adding space created duplicate users
This fixes #4763 where adding space created duplicate viewlevels
avatar mbabker mbabker - change - 22 Nov 2014
Milestone
avatar mbabker mbabker - change - 22 Nov 2014
Milestone Added:
avatar mbabker mbabker - change - 22 Nov 2014
Milestone Added:
avatar mbabker mbabker - change - 22 Nov 2014
Milestone

Add a Comment

Login with GitHub to post a comment