UI enhancement
avatar brianteeman
brianteeman
25 Aug 2014

Steps to reproduce the issue

Filter the CMS tracker on the postgres category

Expected result

I expected to see the colored text postegres visible on that page

Actual result

Its only visible inside the issues

System information (as much as possible)

Additional comments

Really not worth categorising stuff if people cant see it

avatar brianteeman brianteeman - open - 25 Aug 2014
avatar brianteeman
brianteeman - comment - 25 Aug 2014

Plus it makes it really hard to go through and see what needs to go in a category if I cant easily see that on the index page

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

avatar allenzhao
allenzhao - comment - 26 Aug 2014

Since we have labels, I'd say we can put the categories "badge" or "label" before the labels on list.

Cheers | 顺颂时祺
Allen Zhao | 赵泽涵

在 2014年8月26日,2:52,Brian Teeman notifications@github.com 写道:

Plus it makes it really hard to go through and see what needs to go in a category if I cant easily see that on the index page

This comment was created with the J!Tracker Application at http://issues.joomla.org/.


Reply to this email directly or view it on GitHub.

avatar b2z
b2z - comment - 26 Aug 2014

Since we have labels, I'd say we can put the categories "badge" or "label" before the labels on list.

Would not this be a mess, mixing labels and categories in one row?

avatar allenzhao
allenzhao - comment - 26 Aug 2014

Would not this be a mess, mixing labels and categories in one row?

I'm thinking of something like this(it's ugly):
screenshot 2014-08-26 15 56 33

It is a little bit messy though. But since category is an multiple map (like labels), so another column is not a good choice. And another line might also be ugly; like this:
screenshot 2014-08-26 16 00 43

Anyway I think it's not a very good idea to add some "label" element on the current list.

avatar brianteeman
brianteeman - comment - 26 Aug 2014

Why not have the category label in a column?

Otherwise to be honest there is no point at all in having the categories if
you cant see them on the list view

On 26 August 2014 09:01, Zehan Zhao notifications@github.com wrote:

Would not this be a mess, mixing labels and categories in one row?

I'm thinking of something like this(it's ugly):
[image: screenshot 2014-08-26 15 56 33]
https://cloud.githubusercontent.com/assets/3326332/4041491/8f19c6b4-2cf6-11e4-95cc-052857fccf5b.png

It is a little bit messy though. But since category is an multiple map
(like labels), so another column is not a good choice. And another line
might also be ugly; like this:
[image: screenshot 2014-08-26 16 00 43]
https://cloud.githubusercontent.com/assets/3326332/4041521/1a53bf5a-2cf7-11e4-8bda-3f8a71104f69.png

Anyway I think it's not a very good idea to add some "label" element on
the current list.


Reply to this email directly or view it on GitHub
#449 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar brianteeman
brianteeman - comment - 26 Aug 2014

Ah just saw your comment about it being multiple map which I didnt
realise and dont see the need for

In that case I would go for your second screenshot

On 26 August 2014 10:09, Brian Teeman brian@teeman.net wrote:

Why not have the category label in a column?

Otherwise to be honest there is no point at all in having the categories
if you cant see them on the list view

On 26 August 2014 09:01, Zehan Zhao notifications@github.com wrote:

Would not this be a mess, mixing labels and categories in one row?

I'm thinking of something like this(it's ugly):
[image: screenshot 2014-08-26 15 56 33]
https://cloud.githubusercontent.com/assets/3326332/4041491/8f19c6b4-2cf6-11e4-95cc-052857fccf5b.png

It is a little bit messy though. But since category is an multiple map
(like labels), so another column is not a good choice. And another line
might also be ugly; like this:
[image: screenshot 2014-08-26 16 00 43]
https://cloud.githubusercontent.com/assets/3326332/4041521/1a53bf5a-2cf7-11e4-8bda-3f8a71104f69.png

Anyway I think it's not a very good idea to add some "label" element on
the current list.


Reply to this email directly or view it on GitHub
#449 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar b2z
b2z - comment - 26 Aug 2014

Just wanted to propose the same option as @allenzhao already did on the second screen. I think that it is the only way to place categories nicely.

avatar brianteeman
brianteeman - comment - 26 Aug 2014

Let's make it happen ;)

then I can start to add categories to the issues

On 26 August 2014 11:21, Dmitry Rekun notifications@github.com wrote:

Just wanted to propose the same option as @allenzhao
https://github.com/allenzhao already did on the second screen. I think
that it is the only way to place categories nicely.


Reply to this email directly or view it on GitHub
#449 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar elkuku
elkuku - comment - 26 Aug 2014

:+1: We can have the UI experts discuss later where to place the elements, for now let's care about that they are visible ;=)

avatar b2z b2z - change - 27 Aug 2014
Labels Added: enhancement UI
avatar brianteeman
brianteeman - comment - 30 Aug 2014

Can we commit this please so we can start to use the categories

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

avatar b2z
b2z - assign - 31 Aug 2014
Assigned to b2z
avatar b2z
b2z - comment - 31 Aug 2014

I found two options how to get categories:

  1. For every issue in the list using getCategories() method here
  2. Join over the issue_category_map and issues_categories tables here, then iterate an array of items here to eliminate duplicates and assign list of categories to every item.

The first option is easier, but more performance expensive. The second option is more complicated and I am not sure how to correctly implement it, but it should be less performance expensive (though I also not sure about it).

So I need an advice from @elkuku or @mbabker here ;)

avatar b2z
b2z - comment - 5 Sep 2014

@elkuku or @mbabker please respond :computer:

avatar allenzhao
allenzhao - comment - 5 Sep 2014

Do we have a master/slave DB? If not, I'm for the second option

avatar mbabker
mbabker - comment - 5 Sep 2014

Single DB server.

avatar b2z
b2z - comment - 5 Sep 2014

As I've pointed earlier, I am not sure that option 1 is more performance expensive then option 2. Join of tables is quite expensive operation.

avatar b2z
b2z - comment - 5 Sep 2014

Well second option will not work because of the limit. When you retrieve items you can not know how many of them needed to give exactly the same value as list.limit after elimination of duplicates. Anyone has other thoughts how to implement? If no, I will implement the first option.

avatar brianteeman
brianteeman - comment - 19 Sep 2014

Do you think you can implement option 1 so that we can tag the issues before the next PBF on the 17th. That should be a pretty good test of how it works. If it doesnt we can always rethink the approach afterwards.

This comment was created with the J!Tracker Application at http://issues.joomla.org/.

avatar b2z
b2z - comment - 19 Sep 2014

@brianteeman yes I can. Just a lack of time at the moment. The plan is to implement it till the end of next week :soon:

avatar brianteeman
brianteeman - comment - 19 Sep 2014

Awesome

On 19 September 2014 09:05, Dmitry Rekun notifications@github.com wrote:

@brianteeman https://github.com/brianteeman yes I can. Just a lack of
time at the moment. The plan is to implement it till the end of next week [image:
:soon:]


Reply to this email directly or view it on GitHub
#449 (comment).

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
http://brian.teeman.net/

avatar b2z b2z - reference | - 19 Sep 14
avatar b2z
b2z - comment - 19 Sep 2014

I've had some free time today and made it faster :smiley:

avatar elkuku elkuku - close - 22 Sep 2014
avatar elkuku elkuku - close - 22 Sep 2014
avatar elkuku elkuku - change - 22 Sep 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-09-22 12:13:31

Add a Comment

Login with GitHub to post a comment