Use the successful tested button
JBS Members are able to increment the successful test if there are successful tests by other users that don't push the button (or used github) but add a comment with a successful test.
Reset the successful tests if the PR needs new testing e.g. if the code has big changens and the "old" tests are invalid.
And remove tests if a user unexpected use the button.
We can only add our own tests to the list.
I was thinking to JC there the JBS could add successful tests or remove it. Here the JBS can't do it. :D
Every user should also be able to "revoke" their test results, simply by setting it to "not tested", in case they "unexpectedly" hit the button, maybe this is not so obvious (I hope this is what you meant).
ok. I don't know this. But it works good here. (just tested)
We were talking about implementing a comment parser at some point, but never really got that done, so currently this is not supported.
ok. I don't know what is easyer/better to implement a option for the JBS to add tests by other users (as we have it on JC) or use a comment parser that "find" a successful test.
This comment was created with the J!Tracker Application at http://issues.joomla.org/.
I don't know what is easyer/better to implement a option for the JBS to add tests by other users (as we have it on JC) or use a comment parser that "find" a successful test.
For me an option is much easier then parsing :)
If we do so where we could place it? May be on the comment's bar? And for example if you see @test
in the comment you can click on "Add successful test". This will allow to handle the user of test.
I am not sure about "Add unsuccessful test" option, but this could be placed also there ;)
On the JC tracker there are checkboxes for up to 4 successful tests. We need something like that so it is possible to remove a test result when needed. Maybe a counter to interment/decrement the number of successful tests?
Maybe a counter to interment/decrement the number of successful tests?
It could be on of the options. But the problem here is that you can not track the user of the test. Do not forget that we are tracking users who made a test and displaying them in the list.
Yeah, I am aware you are tracking users of the test. You don't want to clutter the screen with buttons for every comment. A user selector might be too much. A dummy user for these results?
You don't want to clutter the screen with buttons for every comment.
Makes sense.
A dummy user for these results?
Like jissues-bot? ;) Why not.
Yeah, that is a good one. We are all bots
I have to confess that I've been a very inactive JBS member lately but - are there really that many cases where you have to "submit a test result on behalf of another user" ?
In my case more than I like to ;) Already see it happen on the new tracker too where people write their results but do not submit the test form. I guess also because it is a multiple click + page refresh action, too many steps.
Labels |
Added:
enhancement
|
Labels |
Added:
UI
|
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-09-04 17:35:48 |
I suppose you are talking about the
@test
"tag" that was used on joomlacode to indicate a successful test?We were talking about implementing a comment parser at some point, but never really got that done, so currently this is not supported.
I was also thinking about a "reset tests" if there are code changes, but on the other hand, usually this happens for "unsuccessful tests", so you can ping the testers with a "please test again", or something.
Every user should also be able to "revoke" their test results, simply by setting it to "not tested", in case they "unexpectedly" hit the button, maybe this is not so obvious (I hope this is what you meant).