[#426] - Activity changes
- Closed
- 18 Aug 2014
- Medium
- Build: master
- # 426
- Diff
- joomla:activity-changes
- Success continuous-integration/travis-ci The Travis CI build passed Details
User tests: Successful: Unsuccessful:
This will move the code for activity changes out to macros and add some new event types.
| Labels |
Added:
enhancement
|
||
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-08-18 19:04:50 |
Oh merged and forgot to ask - why you put activities.twig file under the /tracker/tpl/ ?
Well I thought it would be nice to have those "parts" under a separated sub directory.
What would be a better place?
Well I thought it would be nice to have those "parts" under a separated sub directory.
May be better name would be partials ? :) Or like in Symfony:
Just like templates, partials are files located in the templates/ directory, and they contain HTML code with embedded PHP. A partial file name always starts with an underscore (_), and that helps to distinguish partials from templates, since they are located in the same templates/ folders.
Sorry I missed that...
I think it's a good idea, "partials" sounds good, but as I understand, Symfony does not put them in a separate directory?
Could you move the files? 
also that fields.twig and tracker.filters.twig?
Great
Tested -> merge in!