? Pending
Pull Request for # 9273

User tests: Successful: Unsuccessful:

avatar muhakh
muhakh
7 Mar 2016

Pull Request for Issue #9273 .

Summary of Changes

I changed the method of the searching form from "post" to "get" to solve the issue.

Testing Instructions

You can go through the instructions in the issue #9273 (comment)

avatar muhakh muhakh - open - 7 Mar 2016
avatar muhakh muhakh - change - 7 Mar 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Mar 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 13 Apr 2016
Rel_Number 0 9273
Relation Type Pull Request for
avatar brianteeman
brianteeman - comment - 13 Apr 2016

This just doesnt seem correct to me - every form in joomla uses post not get

avatar brianteeman brianteeman - change - 13 Apr 2016
Category Components
avatar muhakh
muhakh - comment - 14 Apr 2016

I think I found the problem, it's in the form action. When the "filter-search" is added to it, the issue is solved.
What about adding "filter-search" to the JUri using setVar?

It will be

<?php
    $uri = JUri::getInstance();
    if ($this->state->get('list.filter')):
        $uri->setVar('filter-search', $this->state->get('list.filter'));
    endif;
    ?>
<form action="<?php echo htmlspecialchars($uri->toString()); ?>" method="post" name="adminForm" id="adminForm">

Instead of

<form action="<?php echo htmlspecialchars(JUri::getInstance()->toString()); ?>" method="post" name="adminForm" id="adminForm">
avatar rahultomar rahultomar - test_item - 13 Jul 2016 - Tested successfully
avatar rahultomar
rahultomar - comment - 13 Jul 2016

I have tested this item successfully on 965f19d

Yeah, its working search box shows value and url also with search input


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9327.

avatar roland-d
roland-d - comment - 1 Aug 2016

I agree that changing from get to post is not the correct solution. The search filter shouldn't be added to the URL either. The question actually is, why are the search settings not stored in the session? If you look at the back-end lists, none of the settings are in the URL, they are all stored in the session, the same thing should be done for the front-end.

avatar brianteeman
brianteeman - comment - 3 Aug 2016

I am closing this as it is not a correct solution


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/9327.

avatar joomla-cms-bot joomla-cms-bot - change - 3 Aug 2016
Category Components Front End Components
avatar brianteeman brianteeman - change - 3 Aug 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-08-03 14:34:35
Closed_By brianteeman
avatar brianteeman brianteeman - close - 3 Aug 2016

Add a Comment

Login with GitHub to post a comment