[#8232] - Better Component Config layout
- Closed
- 6 Apr 2016
- Medium
- Build: staging
- # 8232
- Diff
- bygiro:patch-1
- Error continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error Details
User tests: Successful: Unsuccessful:
Better layout when no Label, like for "permissions" fieldset
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
if there is no label in the xml field, the "control-group" input is still rendered with an empty div with class "control-label" and a div with class "controls" (container of the input). the visual layout will be ugly, because the div with class "controls" has "margin-left: 180px;".
in the "permissions" tab, this does not happens, because the label is not completely rendered and the input container doesn't have any "controls" class.
I added an option to do not render the label and to remove the "controls" class if there is no label attribute in the xml field of the form.
I hope I've been a bit more clear. I thought it was clear from the code.
| Category | ⇒ | Administration |
| Status | Pending | ⇒ | Information Required |
From the limited description of what this does I have not been able to test that it does what you say. I also do not understand in what situation you will not have a label.
I am setting this to information required. Please update this with full testing instructions and an explanation of the use case. This will be closed within 4 weeks if not updated.
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8232.
If a field has no label, the name of the field is used.
| Category | Administration | ⇒ | Administration Fields |
| Status | Information Required | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-04-06 20:09:24 |
| Closed_By | ⇒ | brianteeman |
Closed as stated above
This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/8232.
Hi @bygiro I'm not sure what you try to fix? Can you add a bit more description to your issue? Expecial a way to test this PR?